Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIS-16] API Guidelines Revision 4.0 #26

Merged
merged 55 commits into from
May 29, 2024
Merged

[APIS-16] API Guidelines Revision 4.0 #26

merged 55 commits into from
May 29, 2024

Conversation

stephenfuqua
Copy link
Contributor

No description provided.

@stephenfuqua stephenfuqua marked this pull request as ready for review April 1, 2024 19:01
Copy link

@7thFox 7thFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully most of these comments are just notes about clarification. I know a couple might spark discussion further than just updating wording -- I'm fine if they're not hashed out for this document and I expect for some this will be the case. Just want to bring them up since this document brought them to mind and they could potentially be things to at least note as things lacking any solid specification determination on the current de facto implementation in use today.

api-guidelines/v4.0/API-DESIGN-GUIDELINES/README.md Outdated Show resolved Hide resolved
api-guidelines/v4.0/SCOPE.md Show resolved Hide resolved
api-guidelines/v4.0/API-DESIGN-GUIDELINES/RESOURCES.md Outdated Show resolved Hide resolved
api-guidelines/v4.0/API-DESIGN-GUIDELINES/RESOURCES.md Outdated Show resolved Hide resolved
api-guidelines/v4.0/API-DESIGN-GUIDELINES/DISCOVERY-API.md Outdated Show resolved Hide resolved
Comment on lines 18 to 20
* The _required_ resource name corresponds to an entity in the Ed-Fi Unifying
Data Model. Examples of resource names, which are always plural: `students`,
`studentEducationOrganizationAssociations`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding plural, it might be obvious to most, but could be worth specifying that it follows standard english grammar and not "programmer plural" (localEducationAgencys vs localEducationAgencies). Not sure if anyone would actually do that, but it would make sense to me if I saw someone design such a thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

api-guidelines/v4.0/API-DESIGN-GUIDELINES/GET-REQUESTS.md Outdated Show resolved Hide resolved
@stephenfuqua stephenfuqua merged commit 2d73a7c into main May 29, 2024
3 checks passed
@stephenfuqua stephenfuqua deleted the rev-4.0 branch May 29, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants