Recreating Ruby's Enumerable #3

EdCrux · 2020-02-20T22:18:51Z

Thanks in advance for the review. 🚀
This is the development summarize path of recreating Ruby's Enumerable.
my_each, my_each_with_index, my_select, my_all?, my_any? , my_none? my_counter? my_map? and my_inject?

Analyzing the original method does.
Clarifying the algorithm
Testing with different possibilities and values
Building the method
Debugging and comparing with the original

Adding enumerables file

Adding Rubocop, stickler, and the main strutucture of the readme.md file.

Adding my_each and my_each_with_index method that helps to pass through an array or hash to get the values

This method is a filter for array and hashes, it is a copy of select method inside ruby

…s-Ruby-methods into add-enumerable

This method evaluates if each element of the array meets the condition and returns true if all elements meet the condition.

This method evaluates if your are passing a block or a pattern, then iterates into each element and returns true if none element match with the condition

This method provides helps to inject new code to an existing array or range

Fixing bugs my_all? and my_none? methods

Checking bugs when you pass nil as value in the array

Removing linter warnigns with rubocop, debugging and testing myall? adding the logic for working without blocks

Updating link for live preview

Anna-Myzukina · 2020-02-21T20:48:34Z

Pull Request under the review by Anna Muzykina (TSE)

Anna-Myzukina · 2020-02-21T21:11:07Z

Hi @EdCrux !

Status: [changes required]

Good job so far, just a couple more changes and your project can be approved!

Next methods still working not correct:

my_all? this method should return the same thing as ruby's all?
my_any? this method should return the same thing as ruby's any?
my_none? this method should return the same thing as ruby's none?
my_inject this method should return the same thing as ruby's inject

Make changes and submit another code review request.

If you have any questions, let me know on slack (@Anna-Muzykina) and I will be glad to clarify with you.
*Happy coding *

Fixing bugs, and making testing to catch any error

Catching if there are no error in some of the methods

fatymahmed

Hi @EdCrux,

Great job so far 👏👏, most of your methods are working properly, just a few changes and you are good to go.

Check my comments below for a detailed review of your methods. You can also use this as a guide to see the enumerable methods and the different ways each are used (some have different arguments passed).

[OPTIONAL]

Please don't change stickler config as mentioned on Pathwright, see screenshot, the only exception is

You can have Style/CaseEquality cop disabled as described here see Screenshot from Pathwright

Marking this as optional because it was missed in the first review, however, you are highly encouraged to make this change.

Status: Changes Required 🛑
Feel free to reach out to me on slack (Fatima) if you have any questions, I'd be happy to help

fatymahmed · 2020-02-23T08:07:42Z

enumerables.rb

+  def my_all?(data = nil)
+    return my_none?(data) if block_given? && !data.nil?
+
+    arr = to_a
+    return true if arr.empty?
+
+    if block_given?
+      to_a.my_each { |item| return false unless yield(item) }
+    elsif data.nil? && !block_given?
+      to_a.my_each { |item| return false unless item }
+    elsif data.is_a? Class
+      to_a.my_each { |item| return false unless item.is_a? data }
+    elsif data.is_a? Regexp
+      to_a.my_each { |item| return false unless item.to_s.match(data) }
+    end
+    true
+  end


For my_all? handle the case when a pattern other than Regex or a Class is given, it should return true if all of the collection matches the pattern.

For example
The built-in method
[2,3,4,5,6].all?(3) returns false

Your method
[2,3,4,5,6].my_all?(3) returns true

It should return false since not all elements in the array are 3

fatymahmed · 2020-02-23T08:12:34Z

enumerables.rb

+  def my_any?(data = nil)
+    return my_any?(data) if block_given? && !data.nil?
+
+    if block_given?
+      to_a.my_each { |item| return true if yield item }
+      false
+    elsif data.is_a? Regexp
+      to_a.my_each { |item| return true if item.to_s.match(data) }
+    elsif data.is_a? Class
+      to_a.my_each { |item| return true if item.is_a? data }
+    else
+      to_a.my_each { |item| return true if item == data }
+    end
+    false
+  end


For my_any? handle the case when no block or argument is given returns true if at least one of the collection is not false or nil

For example:
The built-in method
[nil, false, nil, false].any? returns false

Your method
[nil, false, nil, false].my_any? returns true

It should return false since all of the elements are either false or nil.

fatymahmed · 2020-02-23T08:14:48Z

enumerables.rb

+  def my_none?(data = nil)
+    return my_none?(data) if block_given? && !data.nil?
+
+    if block_given?
+      to_a.my_each { |item| return false if yield(item) }
+    elsif data.is_a? Regexp
+      to_a.my_each { |item| return false if item.to_s.match(data) }
+    elsif data.is_a? Class
+      to_a.my_each { |item| return false if item.is_a? data }
+    elsif data.nil?
+      to_a.my_each { |item| return false if item }
+    end
+    true
+  end


For my_none? Handle the case when a pattern other than Regex or a Class is given, it returns true only if none of the collection matches the pattern

For example
Built-in method
[5, 'door', 'rod', 'blade'].none?(5) returns false

Your method
[5, 'door', 'rod', 'blade'].my_none?(5) returns true

It should return false since at least 1 element matches the pattern.

fatymahmed · 2020-02-23T08:30:36Z

enumerables.rb

+  def my_inject(*initial)
+    arr = to_a
+    return raise ArgumentError, 'Given arguments 0, expected at least 1' if initial.empty? && !block_given?
+
+    memo = initial.length == 2 && arr.respond_to?(initial[1]) || initial.length == 1 && block_given? ? initial[0] : arr.shift
+    sym = if initial.length == 2
+            initial[1]
+          elsif !block_given? && initial.length == 1 && arr.respond_to?(initial[0])
+            initial[0]
+          else
+            false
+          end
+    arr.my_each { |item| memo = sym ? memo.send(sym, item) : yield(memo, item) }
+    memo
+  end


For my_inject handle the cases

when a symbol is specified, it combines each element of the collection by applying the symbol as a named method

Eg array.my_inject(:+)

it combines all elements of enum by applying a binary operation, specified by a block

Eg Range.new(5, 50).{ |sum, n| sum + n }

Adding some logic to give my_none, my_any and my_all? acept parameter such as numbers

Removing files such as spec folder and rspec

Addign logic to the method to recieve numbers or strings as an argument and start comparing

Removing linter warnings

shshamim63 · 2020-02-24T20:25:30Z

Status ♠️ [Required Changes] ♠️

Hi @EdCrux 👋 ,
Awesome job :clap. Code looks neat and clean and you have covered all the changes asked by the previous reviewer. But I have found three cases where some of the methods malfunctions. The good news is by the pace you are covering the issue I am sure you will nail those too. So lets get to those issues.

👾 [Mandatory Changes] 👾

my_any? identical and returns the same thing as ruby's any?. (Screenshot from Odin)

Enumerables-Ruby-methods/enumerables.rb

Lines 72 to 86 in cac652b

    
           def my_any?(data = nil) 
        
             return my_any?(data) if block_given? && !data.nil? 
        
             if block_given? 
        
               to_a.my_each { |item| return true if yield item } 
        
               false 
        
             elsif data.is_a? Regexp 
        
               to_a.my_each { |item| return true if item.to_s.match(data) } 
        
             elsif data.is_a? Class 
        
               to_a.my_each { |item| return true if item.is_a? data } 
        
             elsif data 
        
               to_a.my_each { |item| return true if item == data } 
        
             end 
        
             false 
        
           end

...1. enumerables my_any? when no block or argument is given returns true if at least one of the collection is not false or nil.

puts [1, nil, false].my_any?   # should return true.
puts [nil, nil, false].my_any?   # should return false. Which I am getting on your one.

my_inject identical and returns the same thing as ruby's inject. (Screenshot from Odin)

Enumerables-Ruby-methods/enumerables.rb

Lines 128 to 142 in cac652b

    
           def my_inject(*initial) 
        
             arr = to_a 
        
             return raise ArgumentError, 'Given arguments 0, expected 1' if initial.empty? && !block_given? 
        
             memo = initial.length == 2 && arr.respond_to?(initial[1]) || initial.length == 1 && block_given? ? initial[0] : arr.shift 
        
             sym = if initial.length == 2 
        
                     initial[1] 
        
                   elsif !block_given? && initial.length == 1 && arr.respond_to?(initial[0]) 
        
                     initial[0] 
        
                   else 
        
                     false 
        
                   end 
        
             arr.my_each { |item| memo = sym ? memo.send(sym, item) : yield(memo, item) } 
        
             memo 
        
           end

...1. my_inject, when a symbol is specified combines each element of the collection by applying the symbol as a named method. But for some cases I am not getting the desired ans that is required. For an example lets execute the following code, after the end of your enumerable module

ARRAY_SIZE = 5
LOWEST_VALUE = 0
HIGHEST_VALUE = 9
array = Array.new(ARRAY_SIZE) { rand(LOWEST_VALUE...HIGHEST_VALUE) }
puts array.my_inject(:+)
puts array.inject(:+)

should get same result printed twice. But not rendering it.

♣️ [Optional Changes] ♣️

multiply_els that uses my_inject as described on Odin (Screenshot from Odin)
There must be a method called multiply_els which uses my_inject. The main purpose of that method is to check your enumerable methods are accessible from outside and you know how to use them properly. But I can not see that on this project. And I am sorry that the previous reviewer did not mention about that one too. So marking this one as optional.

Please fix the above mentioned issue and send another review request.

🌿 Happy Coding 🌿

Shakhawat Hossain

Adding a condition that returns true or false when youe don't pass an argument through the array

Forison

Status Approved💚 💚 💚

Good job on addressing all the issues addressed in the previous reviews🙂

[Optional]

as mentioned in the previous review

There must be a method called multiply_els which uses my_inject. The main purpose of that method is to check your enumerable methods are accessible from ** outside **(outside the module) and you know how to use them properly" multiply_els has to be moved outside the module.

That is it, proceed to the next task

Happy coding

Addo Forison

EdCrux added 15 commits February 12, 2020 09:28

✨ Adding Enumerables file

28d140d

Adding enumerables file

➕ Adding a dependency

f619418

Adding Rubocop, stickler, and the main strutucture of the readme.md file.

✨ Introducing #my_each & #my_each_with_index

da3a651

Adding my_each and my_each_with_index method that helps to pass through an array or hash to get the values

✨ Adding my_select method

5cba342

This method is a filter for array and hashes, it is a copy of select method inside ruby

Updating readmefile

cc83e29

🐛 Fixing a bug with my_all? method

962787d

Merge branch 'add-enumerable' of https://github.com/EdCrux/Enumerable…

48ea0aa

…s-Ruby-methods into add-enumerable

Merging

a43c772

✨ Introducing my_all? and my_any?

a98338a

This method evaluates if each element of the array meets the condition and returns true if all elements meet the condition.

✨ Introducing my_none?

b4d53b5

This method evaluates if your are passing a block or a pattern, then iterates into each element and returns true if none element match with the condition

✨ Introducing my_inject

ca0e8b1

This method provides helps to inject new code to an existing array or range

🐛 Fixing bugs my_all? and my_none? methods

bb633c0

Fixing bugs my_all? and my_none? methods

🐛 Fixing a but related to my_none?

a22be66

Checking bugs when you pass nil as value in the array

🚨 Removing linter warnigns and debugging my_all? method

95476c5

Removing linter warnigns with rubocop, debugging and testing myall? adding the logic for working without blocks

Update Read.me

c47ad74

Updating link for live preview

EdCrux added 2 commits February 21, 2020 15:51

🐛 Fixing bugs,

bf7780b

Fixing bugs, and making testing to catch any error

🥅 Catching errors

6e0fbfb

Catching if there are no error in some of the methods

fatymahmed suggested changes Feb 23, 2020

View reviewed changes

fatymahmed reviewed Feb 23, 2020

View reviewed changes

EdCrux added 4 commits February 23, 2020 22:41

🐛 Fixing bugs over my_all?, my_none?, and my_any?

fa4f114

Adding some logic to give my_none, my_any and my_all? acept parameter such as numbers

🔥 Removing files

87f3da4

Removing files such as spec folder and rspec

⚡ Adding some logic to the method my_none? , my_any?

213081c

Addign logic to the method to recieve numbers or strings as an argument and start comparing

🚨 Removing linter warnings

cac652b

Removing linter warnings

🐛 Fixing a bug of my_any?

7659a6f

Adding a condition that returns true or false when youe don't pass an argument through the array

🐛 Fixing a bug of my_inject method to return the same array.

278d488

Forison approved these changes Feb 25, 2020

View reviewed changes

EdCrux merged commit d1de004 into development Feb 25, 2020

EdCrux deleted the add-enumerable branch February 25, 2020 20:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recreating Ruby's Enumerable #3

Recreating Ruby's Enumerable #3

EdCrux commented Feb 20, 2020 •

edited

Anna-Myzukina commented Feb 21, 2020

Anna-Myzukina commented Feb 21, 2020

fatymahmed left a comment •

edited

fatymahmed Feb 23, 2020

fatymahmed Feb 23, 2020 •

edited

fatymahmed Feb 23, 2020

fatymahmed Feb 23, 2020

shshamim63 commented Feb 24, 2020

Forison left a comment

Recreating Ruby's Enumerable #3

Recreating Ruby's Enumerable #3

Conversation

EdCrux commented Feb 20, 2020 • edited

Anna-Myzukina commented Feb 21, 2020

Pull Request under the review by Anna Muzykina (TSE)

Anna-Myzukina commented Feb 21, 2020

Hi @EdCrux !

Status: [changes required]

Next methods still working not correct:

Make changes and submit another code review request.

fatymahmed left a comment • edited

Choose a reason for hiding this comment

Hi @EdCrux,

fatymahmed Feb 23, 2020

Choose a reason for hiding this comment

fatymahmed Feb 23, 2020 • edited

Choose a reason for hiding this comment

fatymahmed Feb 23, 2020

Choose a reason for hiding this comment

fatymahmed Feb 23, 2020

Choose a reason for hiding this comment

shshamim63 commented Feb 24, 2020

Status ♠️ [Required Changes] ♠️

👾 [Mandatory Changes] 👾

♣️ [Optional Changes] ♣️

Please fix the above mentioned issue and send another review request.

🌿 Happy Coding 🌿

Shakhawat Hossain

Forison left a comment

Choose a reason for hiding this comment

Status Approved💚 💚 💚

Good job on addressing all the issues addressed in the previous reviews🙂

** [Optional] **

That is it, proceed to the next task

Happy coding

Addo Forison

EdCrux commented Feb 20, 2020 •

edited

fatymahmed left a comment •

edited

fatymahmed Feb 23, 2020 •

edited

[Optional]