Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: css_sort #190

Merged
merged 21 commits into from
Jun 4, 2024
Merged

feat: css_sort #190

merged 21 commits into from
Jun 4, 2024

Conversation

EdJoPaTo
Copy link
Owner

closes #189

@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
@github-actions github-actions bot added the stale label Jan 13, 2024
@EdJoPaTo

This comment was marked as outdated.

Sign in to view
@EdJoPaTo EdJoPaTo removed the stale label Jan 13, 2024
@EdJoPaTo

This comment was marked as outdated.

Sign in to view
@EdJoPaTo EdJoPaTo closed this Mar 10, 2024
@Teufelchen1

This comment was marked as outdated.

Sign in to view
@EdJoPaTo EdJoPaTo reopened this May 25, 2024
@EdJoPaTo EdJoPaTo marked this pull request as ready for review May 27, 2024 16:08
@EdJoPaTo
Copy link
Owner Author

Played around with this and the just merged debug_files editor and this is really neat together to understand what happens.

@EdJoPaTo EdJoPaTo requested a review from Teufelchen1 May 27, 2024 16:33
@EdJoPaTo
Copy link
Owner Author

@Hans-Maulwurf With the current state of this feature I'm quite happy. Does the description of it in the README sound helpful to you or do you have any improvement suggestions?

Teufelchen1
Teufelchen1 reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to come back to review the code, let's start with the readme only.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Teufelchen1
Teufelchen1 reviewed May 28, 2024
View reviewed changes
src/editor/css_sort.rs Outdated Show resolved Hide resolved
src/editor/css_sort.rs Outdated Show resolved Hide resolved
src/editor/css_sort.rs Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/editor/css_sort.rs Outdated Show resolved Hide resolved
src/editor/css_sort.rs Show resolved Hide resolved
@EdJoPaTo EdJoPaTo requested a review from Teufelchen1 June 3, 2024 14:05
Teufelchen1
Teufelchen1 reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is completed and good! As usual minor naming and doc nits.

src/editor/css_sort.rs Outdated Show resolved Hide resolved
src/editor/css_sort.rs Show resolved Hide resolved
src/editor/css_sort.rs Outdated Show resolved Hide resolved
@EdJoPaTo EdJoPaTo merged commit f208dcd into main Jun 4, 2024
48 checks passed
@EdJoPaTo EdJoPaTo deleted the css_sort branch June 4, 2024 16:18
@Teufelchen1
Copy link
Collaborator

Nice! 🎉

@EdJoPaTo could you give me feedback on my review(-style)? Was it helpful? Did you perceive me as aggressive or as friendly? Are there certain aspects I should focus more or less on?
Personally I am satisfied as I do have the feeling of positively impacting the merged code quality while simultaneously have learned new things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting/Ordering is changed, but no change in content
2 participants
@EdJoPaTo @Teufelchen1