Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add landscape styling #6

Closed
EdSmilovici opened this issue Aug 12, 2017 · 1 comment
Closed

Add landscape styling #6

EdSmilovici opened this issue Aug 12, 2017 · 1 comment
Assignees
@EdSmilovici

Comments

@EdSmilovici
Copy link
Owner

EdSmilovici commented Aug 12, 2017 •
edited

Currently the website only looks good on devices with a tall aspect ratios, add support for wide aspect ratios
@EdSmilovici EdSmilovici mentioned this issue Aug 12, 2017
Closed
@EdSmilovici EdSmilovici self-assigned this Aug 17, 2017
EdSmilovici added a commit that referenced this issue Aug 19, 2017
@EdSmilovici
Refs #6 Add landscape styling
123186e 
- Added conditional css based on aspect-ratio
- Added logic to sizeSelector() js fn to properly size when in landscape mode
- Added Eventlistener for screen rotation and fire off a resize of the selector
EdSmilovici added a commit that referenced this issue Aug 19, 2017
@EdSmilovici
Revert "Refs #6 Add landscape styling"
8f96b6a 
This reverts commit 123186e.
EdSmilovici added a commit that referenced this issue Aug 19, 2017
@EdSmilovici
Refs #6 Hope this fixes the issue
e18150a 
- removed tmp code shouldn’t have ever been checked in :/
EdSmilovici added a commit that referenced this issue Aug 19, 2017
@EdSmilovici
Refs #6
f607b45 
- missing recommits
EdSmilovici added a commit that referenced this issue Aug 19, 2017
@EdSmilovici
Refs #6 Minor change in hopes of fixing mobile issues
347566c
@EdSmilovici
Copy link
Owner Author

tested on chrome and safari on iphone 5c as well as chrome emulator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EdSmilovici EdSmilovici

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EdSmilovici