Merge pull request #71 from EddieDover/custom-hidden-title

Configurable Cloaked Achievement Title/Description
EddieDover · May 24, 2024 · a2b9da1 · a2b9da1
2 parents 8d9d9e0 + a3f533e
commit a2b9da1
Show file tree

Hide file tree

Showing 9 changed files with 62 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,17 @@
 
+## [1.7.0](https://github.com/EddieDover/fvtt-player-achievements/compare/v1.6.0...v1.7.0) (2024-05-24)
+
+
+### Features
+
+* the text displayed when an achievement is cloaked is now configurable in the settings. ([8096016](https://github.com/EddieDover/fvtt-player-achievements/commit/8096016ab7ebbd1ec172dc736ed597501da32034))
+* verified for Foundry v12 ([4756342](https://github.com/EddieDover/fvtt-player-achievements/commit/47563426b202f5860ed077a29e7df716fd9d7850))
+
+
+### Bug Fixes
+
+* the copy-id button is now hidden if an achievement is cloaked, to prevent spoilers. ([a1fa8d1](https://github.com/EddieDover/fvtt-player-achievements/commit/a1fa8d1b4ebbf1c4f992c643b8c767455c67fc2f))
+
 ## [1.6.0](https://github.com/EddieDover/fvtt-player-achievements/compare/v1.5.0...v1.6.0) (2024-03-17)
 
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "fvtt-player-achievements",
-  "version": "1.6.0",
+  "version": "1.7.0",
   "description": "Player Achievements for Foundry VTT",
   "main": "index.js",
   "author": {

diff --git a/src/lang/en.json b/src/lang/en.json
@@ -28,6 +28,14 @@
       "show-tags-to-players": {
         "name": "Show tags to Players",
         "hint": "Show tags to players, allowing them to filter as well."
+      },
+      "cloak-title-text": {
+        "name": "Cloak Title Text",
+        "hint": "Text to show when an achievement title is cloaked."
+      },
+      "cloak-description-text": {
+        "name": "Cloak Description Text",
+        "hint": "Text to show when an achievement description is cloaked."
       }
     },
     "forms": {

diff --git a/src/lang/es.json b/src/lang/es.json
@@ -28,6 +28,14 @@
       "show-tags-to-players": {
         "name": "Mostrar etiquetas a los jugadores",
         "hint": "Muestre las etiquetas a los jugadores, permitiéndoles filtrar también."
+      },
+      "cloak-title-text": {
+        "name": "Texto del título oculto",
+        "hint": "Texto que se muestra cuando el título de un logro está oculto."
+      },
+      "cloak-description-text": {
+        "name": "Texto de descripción oculto",
+        "hint": "Texto que se muestra cuando la descripción de un logro está oculta."
       }
     },
     "forms": {

diff --git a/src/lang/pt-BR.json b/src/lang/pt-BR.json
@@ -28,6 +28,14 @@
       "show-tags-to-players": {
         "name": "Mostrar tags para os jogadores",
         "hint": "Mostrar tags aos jogadores, permitindo que eles também filtrem."
+      },
+      "cloak-title-text": {
+        "name": "Texto do título oculto",
+        "hint": "Texto exibido quando o título de uma conquista estiver oculto."
+      },
+      "cloak-description-text": {
+        "name": "Texto da descrição oculto",
+        "hint": "Texto exibido quando a descrição de uma conquista estiver oculta."
       }
     },
     "forms": {

diff --git a/src/module.json b/src/module.json
@@ -12,7 +12,6 @@
   "flags": {
     "allowBugReporter": true
   },
-  "allowBugReporter": true,
   "socket": true,
   "languages": [
     {
@@ -44,10 +43,10 @@
       "url": "https://github.com/eddiedover/"
     }
   ],
-  "version": "1.6.0",
+  "version": "1.7.0",
   "compatibility": {
     "minimum": "11",
-    "verified": "11"
+    "verified": "12"
   },
   "relationships": {
     "requires": [

diff --git a/src/module/app/settings.js b/src/module/app/settings.js
@@ -113,4 +113,22 @@ export const registerSettings = () => {
     "default": true,
     "type": Boolean,
   });
+
+  game.settings.register("fvtt-player-achievements", "cloakTitleText", {
+    "name": "fvtt-player-achievements.settings.cloak-title-text.name",
+    "hint": "fvtt-player-achievements.settings.cloak-title-text.hint",
+    "scope": "world",
+    "config": true,
+    "default": "HIDDEN",
+    "type": String,
+  });
+
+  game.settings.register("fvtt-player-achievements", "cloakDescriptionText", {
+    "name": "fvtt-player-achievements.settings.cloak-description-text.name",
+    "hint": "fvtt-player-achievements.settings.cloak-description-text.hint",
+    "scope": "world",
+    "config": true,
+    "default": "HIDDEN",
+    "type": String,
+  });
 };
diff --git a/src/module/core.js b/src/module/core.js
@@ -210,9 +210,10 @@ export async function getAchivements(overrides) {
       retachievements = retachievements.map((achievement) => {
         if (!achievement.completedActors.includes(callingCharacterId)) {
           if (!achievement.showTitleCloaked) {
-            achievement.title = "HIDDEN";
+            achievement.title = game.settings.get("fvtt-player-achievements", "cloakTitleText");
+            achievement.cloaked = true;
           }
-          achievement.description = "HIDDEN";
+          achievement.description = game.settings.get("fvtt-player-achievements", "cloakDescriptionText");
           achievement.image = achievement.cloakedImage ?? "modules/fvtt-player-achievements/images/default.webp";
         }
         return achievement;

diff --git a/src/templates/achievement-block.hbs b/src/templates/achievement-block.hbs
@@ -9,7 +9,7 @@
       <div class="achievement-block-title-row">
         <div class="achievement-block__title-wrap">
         <p class={{#iflockedachi id}}{{#if hideDetails}}"achievement-block__title-lock"{{else}}"achievement-block__title"{{/if}}{{else}}"achievement-block__title"{{/iflockedachi}}>{{title}}</p>
-        {{#unless hideDetails}}
+        {{#unless cloaked}}
         <div
             class="achievement-block__title-copy"
             title={{id}}