-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTHER] Improve animation color of github of techstack in dark mode #315
Comments
Can I work on this? |
sure 👍 |
@Cahllagerfeld please check it out |
It's still showing the black color in dark mode @Srinja333 |
@MahirMahdi I would like to know if this issue is fixed or if I should work on the fix |
Ig someone has made a PR on it. But it's not merged yet. |
ok |
Can I work on this |
its opened with #316 alreay 👍 |
Yeah Exactly because It doesn't show a good visual hierarchy it should good idea to change the dark color to a light version of its body background color; |
@Cahllagerfeld Hi, is it still open, it seems the assignee is not working on it. can I work on it? |
Yep, as there hasn't been any activity here, I'll assign it to you 👍 |
Should i change the contrast or make it dynamic like white in dark mode and black in light mode,in my opinion the former makes more sense? |
exactly, that's the intended behavior. I think for light mode its fine already, it only requires the adjustment for dark mode 👍 |
Hi, @Cahllagerfeld I've addressed the issue, please take a look at the PR, and let me know if any further modifications or adjustments are required |
What would you like to share?
It would look better if the animation color is changed from black to white in dark mode.
Additional information
No response
The text was updated successfully, but these errors were encountered: