Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Improve animation color of github of techstack in dark mode #315

Closed
MahirMahdi opened this issue Mar 20, 2023 · 15 comments · Fixed by #363
Closed

[OTHER] Improve animation color of github of techstack in dark mode #315

MahirMahdi opened this issue Mar 20, 2023 · 15 comments · Fixed by #363

Comments

@MahirMahdi
Copy link

What would you like to share?

It would look better if the animation color is changed from black to white in dark mode.

Screenshot 2023-03-20 155605

Additional information

No response

@Srinja333
Copy link

Can I work on this?

@Cahllagerfeld
Copy link
Member

sure 👍

@Srinja333
Copy link

@Cahllagerfeld please check it out

@Poonam1607
Copy link

It's still showing the black color in dark mode @Srinja333

@abdullah43577
Copy link

@MahirMahdi I would like to know if this issue is fixed or if I should work on the fix

@MahirMahdi
Copy link
Author

@MahirMahdi I would like to know if this issue is fixed or if I should work on the fix

Ig someone has made a PR on it. But it's not merged yet.

@abdullah43577
Copy link

@MahirMahdi I would like to know if this issue is fixed or if I should work on the fix

Ig someone has made a PR on it. But it's not merged yet.

ok

@anubhav1206
Copy link
Contributor

Can I work on this

@Cahllagerfeld
Copy link
Member

its opened with #316 alreay 👍

@beRajeevKumar
Copy link

beRajeevKumar commented Apr 24, 2023

What would you like to share?

It would look better if the animation color is changed from black to white in dark mode.

Screenshot 2023-03-20 155605

Additional information

No response

Yeah Exactly because It doesn't show a good visual hierarchy it should good idea to change the dark color to a light version of its body background color;
we can use try these three colors:
#ffffff
#e9e9ea
#d3d4d5
all these colors are the tint versions of the main color

@rahul0x00
Copy link
Member

rahul0x00 commented Jul 2, 2023

@Cahllagerfeld Hi, is it still open, it seems the assignee is not working on it. can I work on it?

@Cahllagerfeld
Copy link
Member

Yep, as there hasn't been any activity here, I'll assign it to you 👍

@Cahllagerfeld Cahllagerfeld assigned rahul0x00 and unassigned Srinja333 Jul 2, 2023
@rahul0x00
Copy link
Member

rahul0x00 commented Jul 2, 2023

Should i change the contrast or make it dynamic like white in dark mode and black in light mode,in my opinion the former makes more sense?

@Cahllagerfeld
Copy link
Member

exactly, that's the intended behavior. I think for light mode its fine already, it only requires the adjustment for dark mode 👍

@rahul0x00
Copy link
Member

Hi, @Cahllagerfeld I've addressed the issue, please take a look at the PR, and let me know if any further modifications or adjustments are required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants