-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI text color is light if browser's mode is set to dark mode #342
Comments
Nice catch! |
I think the section in the above screenshot should be black The Modal in the bottom screenshot should take |
Do you want to work on this? |
Yeah, I'd like to fix it |
For the background colors we're having our own defined ones. For the modal, we can use On the top screenshot, I might use What do you think? |
Ah okay, I just fixed the colors by using the class names defined I feel like black is standing out a little but If that's what we want then I will make a PR for it, personally I think we can some shade of neutral like neutral-100 or something 😅 Would appreciate any suggestion 😁 |
I think your suggestion of use the neutral tone instead of pure black is better 👍 |
Description
Just noticed the features page with light text
I was using firefox using dark mode theme in firefox,
I am not sure if this is only a firefox specific issue but I think it has to be with the styling of the overview-card component
Screenshots
The text was updated successfully, but these errors were encountered: