Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI text color is light if browser's mode is set to dark mode #342

Closed
Skyhero-alt opened this issue May 21, 2023 · 8 comments · Fixed by #349
Closed

UI text color is light if browser's mode is set to dark mode #342

Skyhero-alt opened this issue May 21, 2023 · 8 comments · Fixed by #349

Comments

@Skyhero-alt
Copy link
Contributor

Skyhero-alt commented May 21, 2023

Description

Just noticed the features page with light text
I was using firefox using dark mode theme in firefox,
I am not sure if this is only a firefox specific issue but I think it has to be with the styling of the overview-card component

Screenshots

image
image

@Cahllagerfeld
Copy link
Member

Nice catch!
I was able to reproduce this 👍

@Cahllagerfeld
Copy link
Member

Cahllagerfeld commented May 21, 2023

I think the section in the above screenshot should be black #000000

The Modal in the bottom screenshot should take bg-skin-off-background. In the modal the headline would also need to be a light text in dark mode

@Cahllagerfeld
Copy link
Member

Do you want to work on this?

@Skyhero-alt
Copy link
Contributor Author

Yeah, I'd like to fix it

@Skyhero-alt
Copy link
Contributor Author

Skyhero-alt commented May 21, 2023

Are colors like this ok
image

The background color in the above screenshot is: bg-neutral-200

image

The background modal color in the above screenshot is: bg-neutral-100
The headline featurescolor is:text-gray-400`

Is this fine or do I have to change anything ?

@Cahllagerfeld
Copy link
Member

For the background colors we're having our own defined ones. For the modal, we can use skin-off-background. For the text we can use text-highlight.

On the top screenshot, I might use bg-black to have a bit more contrast.

What do you think?

@Skyhero-alt
Copy link
Contributor Author

Ah okay, I just fixed the colors by using the class names defined

image


The one with black background
image

I feel like black is standing out a little but If that's what we want then I will make a PR for it, personally I think we can some shade of neutral like neutral-100 or something 😅

Would appreciate any suggestion 😁

@Cahllagerfeld
Copy link
Member

I think your suggestion of use the neutral tone instead of pure black is better 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants