Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme.md added my name #2356

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

vikaskumar2703
Copy link
Contributor

What changes does this PR do?

ADDS MY NAME TO README.MD

Screenshots (If any)

Questions

@github-actions github-actions bot added the small label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Welcome @vikaskumar2703! Thank you so much for your first pull request! Welcome to the community. Also join us in the EddieHub Discord for realtime chat and calls http://discord.eddiehub.org

@vikaskumar2703
Copy link
Contributor Author

can i have my pr reviewed and merged so everything gets clear to me how a contribution is done.

Copy link
Member

@ewainy ewainy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution, happy to merge 😊

@ewainy ewainy merged commit 488b2bb into EddieHubCommunity:main Jan 9, 2023
@vikaskumar2703 vikaskumar2703 deleted the learning branch January 9, 2023 09:55
@vikaskumar2703
Copy link
Contributor Author

thank u for approving and merging my first pr

@ewainy
Copy link
Member

ewainy commented Jan 9, 2023

You're welcome 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants