Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #37

Closed
wants to merge 1 commit into from
Closed

Conversation

mr-c
Copy link

@mr-c mr-c commented Sep 15, 2023

@mr-c mr-c changed the base branch from master to develop September 15, 2023 08:59
@mr-c mr-c changed the base branch from develop to master September 15, 2023 08:59
@cryptogenomicon
Copy link
Member

I'll leave this to Eric as lead developer for the ultimate decision, but in my opinion, we would want to see a different way of addressing this issue. The proposed PR would create a difference in Infernal output file formats that depends on the setting of an environment variable at build time. We really want Infernal output formats to be consistent across platforms and builds, and this is a much higher priority for us than the objective of the reproducible-builds effort.

@cryptogenomicon
Copy link
Member

(Also, we'd need the base branch to be develop, not master. Our master branches are stable branches that correspond to the most recent release version, and we don't modify on a master branch between releases.)

@nawrockie
Copy link
Member

I agree with @cryptogenomicon , so I'm closing without merging.

@nawrockie nawrockie closed this Sep 22, 2023
@mr-c
Copy link
Author

mr-c commented Sep 22, 2023

Note that we have been carrying this patch in the Debian package of infernal since 2019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants