Sending a view property will place ad in that view #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing this, we can now show multiple advertisements on one page.
…-admob # Conflicts: # demo/app/App_Resources/Android/src/main/AndroidManifest.xml # demo/app/app.css # demo/app/app.ts # demo/app/main-page.xml # demo/app/main-view-model.ts # demo/package-lock.json # demo/package.json # src/package.json
# Conflicts: # package.json # src/admob.ios.js
|
Has this ever been merged? I am getting "AdMob error: Error: This value is not a native object" error when pointing view property to an image object. My goal is to show the image when no banner is ad shown. Is the view property supported for banner ads? Can anyone share a working sample code? Thank you! |
|
This has not been merged unfortunately because the changeset is polluted with many files that probably were committed by accident (check the "files changed") tab. I can only accept PRs that focus on fixing the issue as this is impossible to code review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will place the advertisement in the view you send. Before, that view would always get overwritten by the view of the rootViewController. Now, it simply checks if the view is present, and if it isn't it will take the key window.