Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

UIWebView usage and ITMS-90809: Deprecated API Usage #1380

Closed
nickykln opened this issue Aug 29, 2019 · 11 comments
Closed

UIWebView usage and ITMS-90809: Deprecated API Usage #1380

nickykln opened this issue Aug 29, 2019 · 11 comments
Labels
iOS Upstream Problem in the Firebase SDK
Milestone

Comments

@nickykln
Copy link
Contributor

Hello Sir @EddyVerbruggen

As you may know there is a deprecation warning sent from today related to the usage of UIWebView

I have read that firebase still contains references to this deprecated library.

firebase/firebase-ios-sdk#3722

This issue concerns Dynamics Links but I am not using this component, that is why I am not sure that is the root cause of this warning that will be a blocking issue for AppStore submissions soon :(

"dynamic_links": false, in ny firebase.nativescript.json

If you have time to have a look ? If anyone has the same issue ?

Thanks a lot,

N

@EddyVerbruggen
Copy link
Owner

We'll have to wait for Google to publish a new version of their SDK first. Thx for the heads-up!

@EddyVerbruggen EddyVerbruggen added this to the 9.2.0 milestone Aug 29, 2019
@EddyVerbruggen EddyVerbruggen added iOS Upstream Problem in the Firebase SDK labels Aug 29, 2019
@EddyVerbruggen
Copy link
Owner

Almost there, see firebase/firebase-ios-sdk#3723 (comment)

@NathanWalker
Copy link
Contributor

NathanWalker commented Sep 6, 2019

Looks like they published 6.8.0 now (https://github.com/CocoaPods/Specs/blob/master/Specs/0/3/5/Firebase/6.8.0/Firebase.podspec.json). Curious if any code changes needed you think @EddyVerbruggen or can we just bump cocoapod versions?

@EddyVerbruggen
Copy link
Owner

@NathanWalker Usually they break things which you may or may not notice based on the features you (don't) use.

I always wait for them to be happy with the release and post the release notes here: https://firebase.google.com/support/release-notes/ios

@nuno-morais
Copy link

@EddyVerbruggen
Copy link
Owner

I checked yesterday and 6.8.0 was not mentioned. Thx for the heads up!

Btw this may take me some time because there are a few nasty build errors in this release.

@EddyVerbruggen
Copy link
Owner

EddyVerbruggen commented Sep 16, 2019

The build issues I mentioned are related to MLKit and tns-ios, but the team has solved it in 6.1.0, so if you're running tns-ios 6.1.0+ and Firebase plugin 10.0.0 you will be good. I'll release it tomorrow.

@EddyVerbruggen
Copy link
Owner

10.0.0 is out. Hope that helps.

@nitrotm
Copy link

nitrotm commented Oct 11, 2019

@EddyVerbruggen
I still get that message from Apple even after upgrading to 10.0.0. I have cross-checked by removing all other dependencies. Everything pass except if I add nativescript-pluging-firebase to the project.

Here's my firebase.nativescript.json:

{
    "external_push_client_only": false,
    "using_ios": true,
    "using_android": true,
    "firestore": false,
    "realtimedb": false,
    "authentication": false,
    "remote_config": false,
    "performance_monitoring": false,
    "messaging": true,
    "in_app_messaging": false,
    "crashlytics": false,
    "crash_reporting": false,
    "storage": false,
    "functions": false,
    "facebook_auth": false,
    "google_auth": false,
    "admob": false,
    "invites": false,
    "dynamic_links": false,
    "ml_kit": true,
    "ml_kit_text_recognition": false,
    "ml_kit_barcode_scanning": true,
    "ml_kit_face_detection": false,
    "ml_kit_image_labeling": false,
    "ml_kit_custom_model": false,
    "ml_kit_natural_language_identification": false,
    "ml_kit_natural_language_smartreply": false
}

@nitrotm
Copy link

nitrotm commented Oct 14, 2019

Ok, tried with latest pods today, and it seems fixed:

Firebase (6.10.0)
FirebaseAnalytics (6.1.3)
FirebaseAnalyticsInterop (1.4.0)
FirebaseCore (6.3.1)
FirebaseCoreDiagnostics (1.1.1)
FirebaseCoreDiagnosticsInterop (1.0.0)
FirebaseInstanceID (4.2.5)
FirebaseMLCommon (0.19.0)
FirebaseMLVision (0.19.0)
FirebaseMLVisionBarcodeModel (0.19.0)
FirebaseMessaging (4.1.6)

I had the following before:

Firebase (6.9.0)
FirebaseAnalytics (6.1.2)
FirebaseAnalyticsInterop (1.4.0)
FirebaseCore (6.3.0)
FirebaseCoreDiagnostics (1.1.0)
FirebaseCoreDiagnosticsInterop (1.0.0)
FirebaseInstanceID (4.2.5)
FirebaseMLCommon (0.18.0)
FirebaseMLVision (0.18.0)
FirebaseMLVisionBarcodeModel (0.18.0)
FirebaseMessaging (4.1.5)

@cuijinfeng68
Copy link

https://firebase.google.com/support/release-notes/ios#dynamic-links

It was already updated...

how to update it? pod repo update? After I update ,but it does not work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Upstream Problem in the Firebase SDK
Projects
None yet
Development

No branches or pull requests

6 participants