Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Error TS2656: Exported external package typings file '[...]/node_modules/nativescript-plugin-firebase/firebase.d.ts' is not a module. #179

Closed
giordy opened this issue Oct 17, 2016 · 4 comments
Labels
Milestone

Comments

@giordy
Copy link
Contributor

giordy commented Oct 17, 2016

Hello,

I floowed the instructions in the README file but I keep getting this error:

app/app.component.ts(13,27): error TS2656: Exported external package typings file '/home/gio/GIT/xyz/node_modules/nativescript-plugin-firebase/firebase.d.ts' is not a module. Please contact the package author to update the package definition.

Could it be that some intervention is needed on firebase.d.ts, as the error says?

Thanks

@ullalaaron
Copy link

I've also encountered the same issue.
As a temporary fix I removed the typings line in the package.json of the plugin.
Eddy, do you have more insight on this?

@giordy
Copy link
Contributor Author

giordy commented Oct 17, 2016

I just found out that if Typescript is updated to version 2.0.3 the error disappears.

Perhaps it could be a good idea to add a disclaimer in the README? The stub apps coming from NativeScript include version 1.8.10 of TypeScript (at least the ones I used, perhaps now this has changed).

@EddyVerbruggen
Copy link
Owner

@giordy That's ok, are you willing to do a PR?

@giordy
Copy link
Contributor Author

giordy commented Oct 17, 2016

@EddyVerbruggen sure, working on it

EddyVerbruggen added a commit that referenced this issue Oct 18, 2016
Fix typings, addresses issue #179
@giordy giordy closed this as completed Oct 20, 2016
@EddyVerbruggen EddyVerbruggen added this to the 3.7.2 milestone Nov 8, 2016
EddyVerbruggen added a commit that referenced this issue Apr 18, 2017
Fix typings, addresses issue #179
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants