Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Support for AdMob #55

Closed
jlooper opened this issue Jun 14, 2016 · 5 comments
Closed

Support for AdMob #55

jlooper opened this issue Jun 14, 2016 · 5 comments
Milestone

Comments

@jlooper
Copy link
Contributor

jlooper commented Jun 14, 2016

Another opportunity to reduce the amount of plugins installed would be the ability to use Firebase's built-in AdMob integration. Seems like a great opportunity to augment a three-in-one plugin install.

thanks!

@EddyVerbruggen
Copy link
Owner

Hey Jen,

The problem with adding all these additional features is that Firebase requires additional SDK's to be loaded. For AdMob, Facebook (2 even), Google (1 for login, 1 for Push), and so on.

If I'd enable all of those by default your app would:

  • Take forever to build
  • Be slower because some of those require bootstrapping
  • Be much bigger (apk/ipa size)

On top of that builds would occasionally fail because of unresolved dependencies (network hickups, SDK version bumps, etc). And MultiDex would be required as standard for Android.

And some of those SDK's require manual setup because a plugin can't manipulate certain files (specific .plist entries, .gradle files, app.js).

All of that will make this plugin unusable (you've had your own share already).

So what I'm planning is adding these features to the plugin API but if you want to use fi. AdMob then you have to manually edit a few config files. Mostly that means uncommenting a line in a Podfile or .gradle file.

@jlooper
Copy link
Contributor Author

jlooper commented Jun 14, 2016

So they would be available in this plugin, but you enable them ad hoc? Sounds good to me.

@EddyVerbruggen
Copy link
Owner

Also see this awesome PR: #101

@calebeaires
Copy link

calebeaires commented Aug 13, 2016

I have implemented on Google Service Ads LITE to this project and also installed you nativescript-admob without the dependence copile on its include.gradle. Everthing works well.

dependencies {
     ...
     compile 'com.google.android.gms:play-services-ads-lite:9.4.0'
 }

The size of APK doesn't get much bigger. More about it on Firebase Google Mobile Ads Lite SDK

EddyVerbruggen pushed a commit that referenced this issue Feb 17, 2017
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
EddyVerbruggen pushed a commit that referenced this issue Feb 17, 2017
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
@EddyVerbruggen EddyVerbruggen added this to the 3.10.0 milestone Feb 17, 2017
@EddyVerbruggen
Copy link
Owner

Added in 3.10.0

EddyVerbruggen added a commit that referenced this issue Apr 18, 2017
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
EddyVerbruggen added a commit that referenced this issue Apr 18, 2017
#55 Support for AdMob
#85 Google Service conflits on using nativescript-admob with this plugin
#284 nativescript-plugin-firebase and nativescript admob conflict
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants