-
Notifications
You must be signed in to change notification settings - Fork 448
Support for AdMob #55
Comments
Hey Jen, The problem with adding all these additional features is that Firebase requires additional SDK's to be loaded. For AdMob, Facebook (2 even), Google (1 for login, 1 for Push), and so on. If I'd enable all of those by default your app would:
On top of that builds would occasionally fail because of unresolved dependencies (network hickups, SDK version bumps, etc). And MultiDex would be required as standard for Android. And some of those SDK's require manual setup because a plugin can't manipulate certain files (specific .plist entries, .gradle files, app.js). All of that will make this plugin unusable (you've had your own share already). So what I'm planning is adding these features to the plugin API but if you want to use fi. AdMob then you have to manually edit a few config files. Mostly that means uncommenting a line in a Podfile or .gradle file. |
So they would be available in this plugin, but you enable them ad hoc? Sounds good to me. |
Also see this awesome PR: #101 |
I have implemented on Google Service Ads LITE to this project and also installed you nativescript-admob without the dependence copile on its include.gradle. Everthing works well.
The size of APK doesn't get much bigger. More about it on Firebase Google Mobile Ads Lite SDK |
Added in 3.10.0 |
Another opportunity to reduce the amount of plugins installed would be the ability to use Firebase's built-in AdMob integration. Seems like a great opportunity to augment a three-in-one plugin install.
thanks!
The text was updated successfully, but these errors were encountered: