This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Custom auth #49
Merged
Custom auth #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 8, 2016 16:29
…oken provide function to the login.
|
Impressive stuff! Thanks for sharing this. I'll merge it later today and resolve some merge conflicts on my local copy because I'm currently working on Facebook auth as well :) |
|
I haven't tested the CUSTOM LoginType in the iOS platform. |
|
I will be testing your changes this weekend, and fixing stuff if needed. Then I'll finalize Facebook login and grant you commit access. Cheers, |
|
Facebook auth (and |
EddyVerbruggen
added a commit
that referenced
this pull request
Apr 18, 2017
Let me merge this now and I will give you commit access to this repo later. First I want to finalize Facebook login before we run into merge conflicts :) Thanks so much for your contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution for issue #47
Added LoginType CUSTOM that uses the underlying Android FirebaseAuth#signInWithCustomToken and iOS FIRAuth#signInWithCustomToken functions.
See: