Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new DiagnosticOk highlight #378

Merged
merged 1 commit into from Sep 27, 2023

Conversation

stevearc
Copy link
Contributor

Neovim 0.9 added a new DiagnosticOk highlight neovim/neovim#21286

@EdenEast
Copy link
Owner

Thanks for the PR it looks good. I am good to merge this but will hold off as I think you might have made the commit with the wrong git creds (guessing the commit one is your work's 😜)

@stevearc
Copy link
Contributor Author

Agh, you are correct! Fixed.

@EdenEast
Copy link
Owner

No worries. For future git lets you conditionally include other files using includeIf. An example of this would be

[includeIf "gitdir:~/personal/"]
    path = "~/.local/share/git/per.conf"

per.conf could set your get creds like name, email, gpg key, etc.
This would include per.conf if the git dir path start with ~/personal as an example. This has saved me multiple times.

My setup has ~/.config/git/config loading the file ~/.local/share/git/config that is where I put per machine configuration. This file is where I have this snippet.

Hope this helps.

@EdenEast EdenEast merged commit fe2fc7b into EdenEast:main Sep 27, 2023
8 checks passed
@stevearc stevearc deleted the stevearc-diagnostic branch September 27, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants