Sam/floating-nav-bug #5102
Closed
Sam/floating-nav-bug #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After many attempts to throwing many "setTimeout" hacks at this bug in order to jolt the scene to update its styles, I gave up and found an alternative solution. The reason for giving up was because setTimeout had nasty side-effects and caused the animation to become glitchy in various ways. I wasn't confident that even if I got the "setTimeout" stategry working, that it wouldn't cause some other unforseen regression. So, the alternative is to disable then re-enable the keyboard controller during scene transition. By doing this, it causes the internal react context for the keyboard controller library to update. The context updating causes all dependencies on the reanimated shared value to be resestablished and this jolts the scene back into the correct state.
|
We've decided to just upgrade reanimated to an RC release: 5e151c5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After many attempts to throwing many "setTimeout" hacks at this bug in
order to jolt the scene to update its styles, I gave up and found an
alternative solution. The reason for giving up was because setTimeout
had nasty side-effects and caused the animation to become glitchy in
various ways. I wasn't confident that even if I got the "setTimeout"
stategry working, that it wouldn't cause some other unforseen
regression.
So, the alternative is to disable then re-enable the keyboard controller
during scene transition. By doing this, it causes the internal react
context for the keyboard controller library to update. The context
updating causes all dependencies on the reanimated shared value to be
resestablished and this jolts the scene back into the correct state.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: