Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sam/floating-nav-bug #5102

Closed
wants to merge 3 commits into from
Closed

Sam/floating-nav-bug #5102

wants to merge 3 commits into from

Commits on Jun 18, 2024

  1. Fix Podfile.lock Yoga hash

    @samholmes
    samholmes committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    abef9b2 View commit details
    Browse the repository at this point in the history

  2. Upgrade react-native-keyboard-controller@^1.12.3

    @samholmes
    samholmes committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c7b2aa1 View commit details
    Browse the repository at this point in the history

  3. Update floating-nav hacky fix to be less hacky but still hacky 

    After many attempts to throwing many "setTimeout" hacks at this bug in
order to jolt the scene to update its styles, I gave up and found an
alternative solution. The reason for giving up was because setTimeout
had nasty side-effects and caused the animation to become glitchy in
various ways. I wasn't confident that even if I got the "setTimeout"
stategry working, that it wouldn't cause some other unforseen
regression.

So, the alternative is to disable then re-enable the keyboard controller
during scene transition. By doing this, it causes the internal react
context for the keyboard controller library to update. The context
updating causes all dependencies on the reanimated shared value to be
resestablished and this jolts the scene back into the correct state.
    @samholmes
    samholmes committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cbbfc16 View commit details
    Browse the repository at this point in the history