Check for clock skew on login #1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Feb 19, 2019
| <dict> | ||
| <key>NSIncludesSubdomains</key> | ||
| <true/> | ||
| <key>NSExceptionAllowsInsecureHTTPLoads</key> |
There was a problem hiding this comment.
I don't believe this will work in production apps as Apple is strict about https
| // Check clock skew against atomic time | ||
| try { | ||
| const remoteTime = await fetch('http://worldtimeapi.org/api/timezone/Etc/GMT') | ||
| const body = await remoteTime.json() |
There was a problem hiding this comment.
Do not put a blocking network call in initAccount as this can slow down login times for users. This should run in the background and throw a modal once complete.
There was a problem hiding this comment.
Also, we should probably have this at app startup time instead of initAccount as the user might not be able to login at all. This would entail moving almost the entire PR to the edge-login-ui repo which is a good idea so SDK partners get it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Requirements
If you have made any visual changes to the GUI. Make sure you have:
Subtask of https://app.asana.com/0/361770107085503/838231819659034/f