Jon/fix/coin-rank-default-fiat #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Apr 27, 2023
| @@ -11,6 +11,9 @@ import { getSymbolFromCurrency } from '../../constants/WalletAndCurrencyConstant | |||
| import { formatFiatString } from '../../hooks/useFiatText' | |||
| import { useHandler } from '../../hooks/useHandler' | |||
| import { formatDate } from '../../locales/intl' | |||
| import { getDefaultFiat } from '../../selectors/SettingsSelectors' | |||
There was a problem hiding this comment.
pass fiat as param from router
src/components/charts/SwipeChart.tsx
Outdated
| const rawChartData = marketChartRange.prices.map(rawDataPoint => { | ||
| return { | ||
| x: new Date(rawDataPoint[0]), | ||
| y: parseFloat(convertCurrencyFromExchangeRates(exchangeRates, 'iso:USD', `iso:${defaultFiat}`, rawDataPoint[1].toString())) |
There was a problem hiding this comment.
Use getHistoricalRate to prevent using redux
Jon-edge
force-pushed
the
jon/fix/coin-rank-default-fiat
branch
from
b9f00fd
to
d6dbc77
Compare
paullinator
approved these changes
May 1, 2023
Jon-edge
force-pushed
the
jon/fix/coin-rank-default-fiat
branch
from
d6dbc77
to
1f3753a
Compare
Jon-edge
force-pushed
the
jon/fix/coin-rank-default-fiat
branch
from
1f3753a
to
8880b64
Compare
Also implement UX audit feedback of clarifying the timespan button labels.
Ensure localized decimal characters are used
Jon-edge
force-pushed
the
jon/fix/coin-rank-default-fiat
branch
from
8880b64
to
bf3218f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: