Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply withWallet to WcConnectScene #5104

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Apply withWallet to WcConnectScene #5104

merged 1 commit into from
Jun 20, 2024

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Jun 19, 2024

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Copy link
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like fixing a symptom. Going by the stack trace, this scene shouldn't be mounted. You can't navigate directly to WcConnectScene or deeplink to it without first navigating to WcConnectionsScene and that's not in the stack.

@swansontec swansontec merged commit 2fc245c into develop Jun 20, 2024
2 checks passed
@swansontec swansontec deleted the william/wc-crash branch June 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants