Jon/fix/swap-navigation #5105
Merged
Jon/fix/swap-navigation #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/fix/swap-navigation
branch
from
1d5e489
to
75f9739
Compare
swansontec
approved these changes
Jun 20, 2024
Jon-edge
force-pushed
the
jon/fix/swap-navigation
branch
from
75f9739
to
ad1d391
Compare
- CircleTimer never gets unmounted as expected. Stale timers from prior swaps will keep firing indefinitely. - SwapConfirmationScene also remains mounted when unfocused, and auto-refreshes with stale data from swaps that never approved can happen from unmounted instances. This can occur when the scene is focused with an unapproved quote, and the Exchange tab is tapped. That *should* fully reset the flow/state to the beginning but no longer does post-nav upgrade.
Jon-edge
force-pushed
the
jon/fix/swap-navigation
branch
from
ad1d391
to
23efa98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack-fix React Navigation bug for swap scenes
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: