Jon/fix/balance-loading #5108
Merged
Jon/fix/balance-loading #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Jun 24, 2024
Comment on lines
64
to
67
| const progress = React.useMemo( | ||
| () => (syncableWalletIds.length === 0 ? 100 : 100 * (syncedWallets / syncableWalletIds.length)), | ||
| [syncableWalletIds.length, syncedWallets] | ||
| ) |
There was a problem hiding this comment.
Don't use a memo here. The useMemo hook needs to loop over its dependency array to see if anything has changed, which is going to cost more than just re-doing the division on each run. Math is really fast.
There was a problem hiding this comment.
Also, I request that this hook return a value in the range of 0-1, and have the name useAccountSyncRatio. That makes it clearer what the units are, and mirrors the fact that the wallets themselves operate on a 0-1 scale. Visual components like the sync bar can convert the range as necessary for display purposes (like 0% - 100%).
Jon-edge
force-pushed
the
jon/fix/balance-loading
branch
7 times, most recently
from
18b7236
to
19224b4
Compare
paullinator
force-pushed
the
jon/fix/balance-loading
branch
from
19224b4
to
1ef0154
Compare
|
/rebase |
Cause of regression might have been due to the changes made for faster login
For indicating total balance isn't fully ready yet
cacf5b1 used the container style as a text style. Height is already locked in the container style, no need to re-apply it to the text. Design has also requested that the balance number sits centered vertically between the title and buttons.
Move the layout measurement to the parent component
github-actions
bot
force-pushed
the
jon/fix/balance-loading
branch
from
1ef0154
to
64616e3
Compare
paullinator
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-20.at.17.19.09.mp4
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: