This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
Modified sims module & overall improve speed. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijunaid8989
requested review from
azharmalik3
and removed request for
ijunaid8989
azharmalik3
reviewed
Jan 21, 2019
assets/static/components/sims.vue
Outdated
| }); | ||
| let status = "<span>Not Found.</span>" | ||
| let str = row.last_sms | ||
| let res = str.toLowerCase(); |
There was a problem hiding this comment.
Don't need str variable. Use let res = row.last_sms.toLowerCase();.
azharmalik3
reviewed
Jan 21, 2019
assets/static/components/sims.vue
Outdated
| if (allowance_value == -1.0) { | ||
| yesterday_in_number = "-"; | ||
| let volume_used_yesterday = row.volume_used_yesterday | ||
| if(volume_used_yesterday == '-1.0'){ |
There was a problem hiding this comment.
Create a common for this condition instead of repeat.
azharmalik3
reviewed
Jan 21, 2019
assets/static/components/sims.vue
Outdated
| if (allowance_value == -1.0) { | ||
| percentage_used = "-"; | ||
| let percentage_used = row.percentage_used | ||
| if(percentage_used == '-1.0'){ |
There was a problem hiding this comment.
Same condition code lines.
azharmalik3
reviewed
Jan 21, 2019
assets/static/components/sims.vue
Outdated
| if (allowance_value == -1.0) { | ||
| current_in_number = "-"; | ||
| let volume_used = row.allowance | ||
| if(volume_used == '-1.0'){ |
There was a problem hiding this comment.
Same condition code lines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.