-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores: upgrade to node 20 #77
Conversation
8c7b0a7
to
6e16592
Compare
50d4ce7
to
932dad3
Compare
452b889
to
ae181ff
Compare
1752e7d
to
94422e3
Compare
EdgeTX Buddy has been automatically deployed to Cloudflare. |
@freshollie it's ready for your review at your earliest convenience. Regarding next steps, I think we should probably then start updating the rest of the stack (React, components, etc). Then we could probably start tackling new features (SD card, Cloudbuild FW download, etc). |
EdgeTX Buddy has been automatically deployed to Cloudflare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor points but really amazing job thanks so much!
EdgeTX Buddy has been automatically deployed to Cloudflare. |
Fixes the Github link and Settings menu. See https://www.electronjs.org/docs/latest/tutorial/window-customization#set-custom-draggable-region
EdgeTX Buddy has been automatically deployed to Cloudflare. |
EdgeTX Buddy has been automatically deployed to Cloudflare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing is standing out as problematic, and has had some testing already (Win11). Online preview build seemed to be working fine.
Summary of changes:
20.x
.vitest
to latest.ky
to latest (and removedky-universal
, as Node 18+ provides native support forfetch
API).nock
to14.0.0-beta5
to add support forfetch
API (please note that recording is NOT supported).electron
andelectron-builder
to latest (electron-rebuild
removed on the way).Fixes #60.