Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: upgrade to node 20 #77

Merged
merged 8 commits into from
Apr 15, 2024
Merged

chores: upgrade to node 20 #77

merged 8 commits into from
Apr 15, 2024

Conversation

raphaelcoeffic
Copy link
Member

@raphaelcoeffic raphaelcoeffic commented Apr 7, 2024

Summary of changes:

  • updated Node.js to 20.x.
  • updated vitest to latest.
  • updated ky to latest (and removed ky-universal, as Node 18+ provides native support for fetch API).
  • updated nock to 14.0.0-beta5 to add support for fetch API (please note that recording is NOT supported).
  • updated electron and electron-builder to latest (electron-rebuild removed on the way).
  • a few more minor updates...

Fixes #60.

Copy link

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://721df49b.buddy-7a6.pages.dev
✅ Storybook: https://721df49b.buddy-7a6.pages.dev/storybook

@raphaelcoeffic raphaelcoeffic marked this pull request as ready for review April 11, 2024 16:22
@raphaelcoeffic
Copy link
Member Author

@freshollie it's ready for your review at your earliest convenience.

Regarding next steps, I think we should probably then start updating the rest of the stack (React, components, etc). Then we could probably start tackling new features (SD card, Cloudbuild FW download, etc).

@raphaelcoeffic raphaelcoeffic changed the title WiP: upgrade to node 20 chores: upgrade to node 20 Apr 11, 2024
Copy link

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://74b91682.buddy-7a6.pages.dev
✅ Storybook: https://74b91682.buddy-7a6.pages.dev/storybook

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
freshollie
freshollie previously approved these changes Apr 12, 2024
Copy link
Collaborator

@freshollie freshollie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor points but really amazing job thanks so much!

Copy link

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://75a96a02.buddy-7a6.pages.dev
✅ Storybook: https://75a96a02.buddy-7a6.pages.dev/storybook

Copy link

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://edcd51f0.buddy-7a6.pages.dev
✅ Storybook: https://edcd51f0.buddy-7a6.pages.dev/storybook

Copy link

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://319267c4.buddy-7a6.pages.dev
✅ Storybook: https://319267c4.buddy-7a6.pages.dev/storybook

@pfeerick pfeerick enabled auto-merge (squash) April 15, 2024 00:11
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing is standing out as problematic, and has had some testing already (Win11). Online preview build seemed to be working fine.

@pfeerick pfeerick merged commit f912b8e into main Apr 15, 2024
15 checks passed
@pfeerick pfeerick deleted the node-20 branch April 15, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to click Settings or GitHub icon in App
3 participants