Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glider specific SE audio/phrases for SoarETX #103

Merged
merged 3 commits into from Mar 6, 2024

Conversation

ulfhedlund
Copy link
Contributor

@ulfhedlund ulfhedlund commented Feb 15, 2024

Added glider specific SE audio/phrases for SoarETX, plus a few missing sounds for cars.

Added glider specific audio/phrases for SoarETX and some missing sounds for cars.
@ulfhedlund ulfhedlund changed the title Glider specific audio/phrases for SoarETX Glider specific SE audio/phrases for SoarETX Feb 15, 2024
@pfeerick
Copy link
Member

Just FYI, I'll leave this on hold until #100 goes in, so they stay in sync. I'll generate the audio now though.

@frankiearzu
Copy link
Contributor

frankiearzu commented Feb 27, 2024

@ulfhedlund
Did a few changes to the sounds in SoarETX v2, tried to re-use some existing sounds, and only added a few new ones.

Do you mind chaining this ones:

Already Existing

Disarmed se2drm.wav -> disarm.wav OLD file
Cruise se2cru.wav -> cruise.wav OLD file
Flaps Up se2flu.wav -> flapup.wav OLD file
Flight Mode Lunch se2lch.wav -> fm-lch.wav OLD file
Landing se2lnd.wav -> landin.wav OLD file

New ones (not in current files)

Motor Armed se2arm.wav -> motarm.wav
Power se2pwr.wav -> power.wav
Speed se2spd.wav -> speed.wav
Thermal se2thm.wav -> therml.wav

If you want to try the changes, a self contained ZIP file is here:
Changes to templates due to new sounds, and the main f3j.lua and f5j.lua has a few new changes.

https://github.com/frankiearzu/DSMTools/blob/main/Planes%20and%20Templates/SoarETX_v2.zip

@pfeerick
Copy link
Member

pfeerick commented Mar 6, 2024

@ulfhedlund Does this look (sound?) right now?

@ulfhedlund
Copy link
Contributor Author

@pfeerick - I am travelling/on leave and have been unable to make the changes that @frankiearzu asked for.
I suppose I need to fix that before merge, right? I'll try and do that tonight (within the next few hours).

@ulfhedlund
Copy link
Contributor Author

@pfeerick - you seem to have fixed it all - thanks! OK to go!

@frankiearzu
Copy link
Contributor

looks good to me too, thanks @pfeerick

@pfeerick
Copy link
Member

pfeerick commented Mar 6, 2024

No problem... thanks for the review guys :)

@pfeerick pfeerick merged commit 489a676 into EdgeTX:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants