Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chinese voices #6

Merged
merged 8 commits into from Oct 14, 2021
Merged

Added Chinese voices #6

merged 8 commits into from Oct 14, 2021

Conversation

zyren
Copy link
Contributor

@zyren zyren commented Aug 10, 2021

A complete Chinese voice files has been produced and tested

@edernucci
Copy link
Collaborator

This is amazing @zyren. I'll proceed with checks and merge asap. Thanks for your contribution.

@richardclli
Copy link

richardclli commented Aug 12, 2021

@zyren We do not want to have manufacturer specific messages in the sound pack, please remove the RadioMaster specific sound, thanks.

@zyren zyren closed this Aug 12, 2021
@zyren zyren reopened this Aug 12, 2021
@zyren
Copy link
Contributor Author

zyren commented Aug 12, 2021

@zyren我们不想在声音包中包含制造商特定的消息,请删除 RadioMaster 特定的声音,谢谢。

Thanks for reminding me ,that Hello.wav has been resubmitted, please review

@zyren
Copy link
Contributor Author

zyren commented Aug 12, 2021

@zyren我们不想在声音包中包含制造商特定的消息,请删除 RadioMaster 特定的声音,谢谢。

抱歉是我搞错了文件,两个文件名被我搞混了,大意了,还望见谅!

@richardclli
Copy link

richardclli commented Aug 13, 2021

Thanks for updating the hello.wav
For the zh-CN.csv, please change the directory name that matches the directory of the voice files, thanks. en->cn
zh-CN.csv的文件夾跟voice的不符,請改一下。

@zyren
Copy link
Contributor Author

zyren commented Aug 13, 2021

Thanks for updating the hello.wav
For the zh-CN.csv, please change the directory name that matches the directory of the voice files, thanks. en->cn
zh-CN.csv的文件夾跟voice的不符,請改一下。

感谢提醒,已经修改为cn

@richardclli
Copy link

I think the Chinese sounds is fine now, @edernucci please consider merging it, thanks.

@pfeerick
Copy link
Member

@edernucci What's happening with this PR? Any ETA?

@edernucci edernucci merged commit a55f8c4 into EdgeTX:main Oct 14, 2021
@edernucci
Copy link
Collaborator

@pfeerick @richardclli sorry about the delay. Will include this on next sound pack release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants