Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PT sound revision #76

Merged
merged 7 commits into from Aug 5, 2023
Merged

PT sound revision #76

merged 7 commits into from Aug 5, 2023

Conversation

zandorsp
Copy link
Contributor

@zandorsp zandorsp commented Aug 3, 2023

Remake of PT sounds keeping original system sounds.

Continuation of #74

@zandorsp zandorsp mentioned this pull request Aug 3, 2023
Closed
pfeerick
pfeerick approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-added DBM and kilometers from your other PR, and generated the audio. If that looks/sounds ok to you, I'll merge. Note that the files get normalised and trimmed on the release build, so they should get louder if they are quiet now.

@pfeerick
Copy link
Member

pfeerick commented Aug 4, 2023

Did you want to add the approriate translations for these since this has just been added?

"456","Reverse Thrust","Reverse Thrust","plane","","revthr.wav"
"457","Reverse Thrust On","Reverse Thrust On","plane","","revon.wav"
"458","Reverse Thrust Off","Reverse Thrust Off","plane","","revoff.wav"
"459","Reverse Thrust Idle","Reverse Thrust Idle","plane","","revid.wav"
"460","Forward Thrust","Forward Thrust","plane","","revfwd.wav"

@zandorsp
Copy link
Contributor Author

zandorsp commented Aug 5, 2023

Well, now looks ok. Ready to merge.

@pfeerick
Copy link
Member

pfeerick commented Aug 5, 2023

Fantastic, thanks for that! :)

@pfeerick pfeerick merged commit 1f5b0e1 into EdgeTX:main Aug 5, 2023
1 check passed
@zandorsp zandorsp deleted the PT-revision branch August 5, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zandorsp @pfeerick