Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup list filters need more work #228

Closed
pfeerick opened this issue Jun 17, 2021 · 5 comments · Fixed by EdgeTX/libopenui#39
Closed

Popup list filters need more work #228

pfeerick opened this issue Jun 17, 2021 · 5 comments · Fixed by EdgeTX/libopenui#39
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios enhancement ✨ New feature or request
Milestone

Comments

@pfeerick
Copy link
Member

For want of a better word, the category/filter icons that appear on the side of lists ...

image

... can make it so you can't see all the list, i.e. if you press the top one for switches, it will only show the 'positive' switch states, not any of the not states, and the second one will only show the sticks... so if you use either filter, you loose access to the not switch states, 'Tele' and 'Act' etc in this examble. Another is if you were in the global functions screen, if you hit one of the filter icons, you can't get at the ON state unless you close and reopen the list - as is see here... => https://youtu.be/Y9OvW9XCjOs?t=1440

Perhaps at minimum an 'all' option is needed so you can always get the full unfiltered list back?

@pfeerick pfeerick added bug 🪲 Something isn't working enhancement ✨ New feature or request color Related generally to color LCD radios labels Jun 17, 2021
@pfeerick
Copy link
Member Author

pfeerick commented Sep 15, 2021

Another suggestion was categories for GVs, LSs and a Misc or something for things like Batt, and Timers

@pfeerick pfeerick added this to the 2.6 milestone Sep 15, 2021
pfeerick added a commit that referenced this issue Nov 30, 2021
Can now enable and disable filters in popup menus (i.e. source, switch)
Active filter is now also highlighted
Use page keys to scroll through filters if no touch
Resolves #228
@JimB40 JimB40 modified the milestones: 2.6, 2.9 Oct 2, 2022
@JimB40
Copy link
Collaborator

JimB40 commented Oct 2, 2022

Partially done in #2435

@JimB40
Copy link
Collaborator

JimB40 commented Oct 2, 2022

  • Reaarange sources' filter icons in two columns so in horizontal layout icons scrolling is not needed.
  • Add top bar with variable name for clarity what is actually changed
  • Add close button on topbar for UI clarity (tapping ouside the the list still works)

@pfeerick
Copy link
Member Author

pfeerick commented Oct 2, 2022

Negative. the changes in #2435 don't relate to this issue, and it's a closed issue anyway ;) The focus of this issue - as per the video - was that you couldn't "undo" a filter selection, which was fixed in 2.6.

@pfeerick pfeerick modified the milestones: 2.9, 2.6 Oct 2, 2022
@Eldenroot
Copy link
Contributor

It is always frustrating to scroll over all items... nightmare, I hope it will be improved in 2.9 somehow :) some QoL improvements are welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants