Fix pots and sliders warning #1277

[eshifri]

Fixes #1277

Summary of changes: it was rather messy. :-)

[pfeerick]

"Here be dragons"? 🐉 ⚔️ 😆

[eshifri]

Well, it is difficult to say what was not wrong there. :-)
The assumptions about what is saved in the model were different in different files. Model_setup assumed that non-existing pots are skipped; switch_warning_dialog and switches - that they are just ignored.
Data type uint8_t was insufficient to keep all 11 bits for 11 pots.
And some other incorrect assumptions in the modl_setup.
I'm afraid looking at the code changes is the shortest way to find it all out. :-)

[pfeerick]

I'm not worried about that... just when I see a comment like "it was rather messy" as the summary I know there are good times ahead! Top marks... We need a contest for the most... entertaining... PR summary! Need some levity after delving in the dark bowels of the code. 😆

[pfeerick]

Thank you... I get it now after reading the code 😁 That explains the odd behaviour I saw with the RS warning being shown, but never actually going away, even though the condition was met.