Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossfire: add barometer altitude sensor #1819

Merged
merged 1 commit into from May 7, 2022
Merged

Crossfire: add barometer altitude sensor #1819

merged 1 commit into from May 7, 2022

Conversation

raphaelcoeffic
Copy link
Member

Until now, Crossfire was only allowing for altitude as part of the GPS sensor. This PR adds barometer support as well.

See betaflight/betaflight#11070.

@pfeerick
Copy link
Member

Oh, nice... so that should end the Matek trickery where they shove the barometer into the GPS packet? :)

I find it funny that it was "tested with FreedomTX v1.32", yet the additional sensor is nowhere to be found! You'd think it would be added it if it was in the protocol, no?🤦

https://github.com/tbs-fpv/freedomtx/blob/23f9fb42e0d26935f146bbb76ca5911dbc303acb/radio/src/telemetry/crossfire.cpp#L28-L60

@raphaelcoeffic
Copy link
Member Author

As it seems, this PR is missing decoding VSpeed which is packed into the same packet on 8-bit using the following packing function (x is in cm/s):
Screenshot 2022-04-15 at 11 47 14

@JimB40
Copy link
Collaborator

JimB40 commented Apr 24, 2022

I find it funny that it was "tested with FreedomTX v1.32", yet the additional sensor is nowhere to be found! You'd think it would be added it if it was in the protocol, no?

Are you using 6.13+ FW?

@pfeerick
Copy link
Member

pfeerick commented Apr 24, 2022

No, that is nothing to do with the crossfire firmware (and would be hard to do since I don't have or use crossfire at all). I was referring to the "tested with FreedomTX v1.32" that was made in betaflight PR. And the lack of the sensor being defined in the firmware... which is sort of necessary for it to work.

@raphaelcoeffic
Copy link
Member Author

Just as a note for now: after discussing with all parties involved, it has been agreed to drop the third byte with VSpeed as this is redundant with the already existing sensor.

@pfeerick pfeerick added enhancement ✨ New feature or request telemetry 📶 labels May 7, 2022
@pfeerick pfeerick added this to the 2.7.1 milestone May 7, 2022
@pfeerick pfeerick merged commit 7806d5f into main May 7, 2022
@pfeerick pfeerick deleted the crsf-baro-alt branch May 7, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request telemetry 📶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants