Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x7): use switch indirection to fetch the proper name #2599

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix(x7): use switch indirection to fetch the proper name #2599

merged 1 commit into from
Oct 19, 2022

Conversation

raphaelcoeffic
Copy link
Member

Fixes #2576

@pfeerick
Copy link
Member

pfeerick commented Oct 18, 2022 •
edited

simu testing suggests this is both toggling the right way, and playing the right file for SWF now ;) Also double-checked against X9D+2019 as to all the down states of all the switches playing the correct sound.

@pfeerick pfeerick added the bug 🪲 Something isn't working label Oct 19, 2022
@pfeerick pfeerick added this to the 2.8 milestone Oct 19, 2022
@pfeerick pfeerick merged commit d7598c8 into main Oct 19, 2022
@pfeerick pfeerick deleted the fix-2576 branch October 19, 2022 11:22
pfeerick pushed a commit that referenced this pull request Oct 31, 2022
@raphaelcoeffic @pfeerick
fix: use switch indirection to fetch the proper name for switch audio (…
7cf2acb 
…#2599)

Fixes #2576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
2.8
Development

Successfully merging this pull request may close these issues.

Some custom model sounds not working
2 participants
@raphaelcoeffic @pfeerick