Companion updates save component settings from Update Settings tab #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elecpower
added
bug 🪲
pfeerick
force-pushed
the
elecpower/cpn-fix-2634-upd-settings
branch
from
a15ad92
to
daec74a
Compare
pfeerick
pushed a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2634
@pfeerick note this is based on 2602 and thus why the big diff. The change for this PR is in https://github.com/EdgeTX/edgetx/compare/elecpower/cpn-fix-2634-upd-settings?expand=1#diff-565c6756adc52a80ae93eaf395cb23b75f09b37d09f4b70e53d6e175af0135c8 lines 252 - 255