Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): RF link alarms #2643

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix(yaml): RF link alarms #2643

merged 1 commit into from
Oct 31, 2022

Conversation

raphaelcoeffic
Copy link
Member

Set warning/critical to default values before reading YAML model file. Otherwise, these values will be 0 if either the old or the new tags are not present, which is the case when coming from 2.7.

Fixes #2591

…ding YAML

Otherwise, these values will be 0 if either the old or the new tags are not present, which is the case when coming from 2.7.
@raphaelcoeffic raphaelcoeffic added this to the 2.8 milestone Oct 29, 2022
@pfeerick
Copy link
Member

pfeerick commented Oct 31, 2022

Looks good on TX16S model that was previously zeros, and can't repo on LR3 anymore. And more tests are always good :)

@pfeerick pfeerick merged commit 6ea4082 into main Oct 31, 2022
@pfeerick pfeerick deleted the fix-2591 branch October 31, 2022 00:38
pfeerick pushed a commit that referenced this pull request Nov 2, 2022
… YAML (#2643)

Otherwise, these values will be 0 if either the old or the new tags are not present, which is the case when coming from 2.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.8 RC2 =>2.8 RC3 telemetry "disable alarms" state changed
2 participants