Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nv14/el18): external module RX inversion #2647

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

raphaelcoeffic
Copy link
Member

The previous state would set/reset PE15 (unused) instead of PI15 (connected to the inverter).

The previous state would set/reset `PE15` (unused) instead of `PI15` (connected to the inverter).
@richardclli
Copy link
Collaborator

I tested this, EL18 v1.0 motherboard, NV14 adapter, RM MPM using 2.8.0 46fc4d9 merged with this PR.
It works properly.

@pfeerick
Copy link
Member

iRangeX IR4X+ MPM is working with EL18 (x2) - but it also worked pre this PR. Is there any readily visible external symptom of PI.15 not having been inverted - a particular module that won't work?

NV14 is being completely non-cooperative with MPM (status no telemetry), rolled back to 2.7.1 with no change, so is unrelated to this PR. ELRS, Ghost and XJT modules appear to be working fine though.

@pfeerick pfeerick added the bug 🪲 Something isn't working label Oct 31, 2022
@pfeerick pfeerick added this to the 2.8 milestone Oct 31, 2022
@pfeerick pfeerick added this to In progress in NV14 via automation Oct 31, 2022
@raphaelcoeffic
Copy link
Member Author

Is there any readily visible external symptom

Not that I know of. Theoretically it should affect using ACCESS modules (there is only R9M ACCESS in this format) on the NV14/EL18, where potentially the polarity of the signal could be wrong (depends on default state of the pin / inverter).

I use "theoretically / potentially" because none of this has been tested.

@pfeerick pfeerick merged commit b409c6f into main Oct 31, 2022
NV14 automation moved this from In progress to Done Oct 31, 2022
@pfeerick pfeerick deleted the fix-nv14-el18-sport-invert branch October 31, 2022 10:58
@pfeerick
Copy link
Member

Well, in that case, some combination of tries R9M instead of R9M ACCESS, wonders why it doesn't work and flip a coin to guess default state of inverter has come into effect. Plus, you know, TX is not RX (except when it is)... 😁

pfeerick pushed a commit that referenced this pull request Nov 2, 2022
The previous state would set/reset `PE15` (unused) instead of `PI15` (connected to the inverter).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
No open projects
NV14
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants