fix(telemetry): sensor processing with legacy polling disabled #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeerick
added
telemetry 📶
bug/regression ↩️
|
TX16S w/ internal MPM using flysky, telemetry warnings and variometer still working good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
External modules using the new module interface (direkt polling of telemetry based on driver) disabled legacy telemetry polling (S.PORT shared pin) to avoid confusing the telemetry parser. However, this fix (see #2504) was implemented poorly and removed sensor processing, which is done in the same function.
External modules / protocol impacted:
ACCESS:R9M ACCESSCRSF: Crossfire, Tracer and ELRSIt would impact basically anything that is related to sensor processing:
Telemetry Lost/Telemetry RecoveredannouncementsFix
This PR fixes the issue by only skipping the polling itself, but not the sensor processing further down in the function.
Fixes #2546
Fixes #2591