Prevent OFF for internal module in hardware settings #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
It seems #2158 is related as well. |
1 task
|
Tested on TX16S, works as should! I suggest to change the "Mode" string under "System" -> "Hardware" -> "Internal RF" in the user interface to "Type" although. As it is not the mode that the user selects there for the internal module, but more which type of internal RF module the radio has. |
|
Changed (only needed for colorlcd as is already "Type" for all of B&W): The other good thing this stops (note sure if it was raised in one of those issues) is the "why does it turn itself back on to X when I turned it off? 😁 |
pfeerick
pushed a commit
that referenced
this pull request
Nov 2, 2022
* Prevent OFF for internal module in hardware settings * chore: Change "Mode" to "Type"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it seems to confuse people and they are trying to set the internal module to
OFFin the hardware settings, let's remove that possibility.To make it clear once more:
Hardware Settings: which module is installed in the radio (we don't actually supportOFFhere)Model Settings: should the internal module be turnedONorOFFfor that model?