Fix CRSF GPS heading precision #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be able to test this for you soon... I have two quads with GPS running CRSF telemetry. This was reported, but only in passing on discord: https://discord.com/channels/839849772864503828/839856795781431317/1058208096704549044 |
|
I ended up doing a walk test so I could eyeball the telemetry... latest nightly was heading was buggy, with this PR heading was perfect. |
pfeerick
pushed a commit
that referenced
this pull request
Apr 13, 2023
ajjjjjjjj
added a commit
to OpenI6X/opentx
that referenced
this pull request
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code there seems something wrong with CRSF GPS heading. I do not think it has been reported, nor do I have the necessary equipment to confirm, but looking at
or betaflight code
/*
0x02 GPS
Payload:
int32_t Latitude ( degree / 10000000 )
int32_t Longitude (degree / 10000000 )
uint16_t Groundspeed ( km/h / 10 )
uint16_t GPS heading ( degree / 100 )
uint16 Altitude ( meter 1000m offset )
uint8_t Satellites in use ( counter )
*/
the current code cannot be right (and in addition, a 16bits uint cannot store 360 * 1000, so a 3 digits precision cannot work)
I would really appreciate if someone with a craft with GPS using CRSF could report