Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(b&w) - Fixes for B&W radio UI screens. #3299

Merged
merged 2 commits into from Mar 8, 2023
Merged

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Mar 4, 2023

Fixes #3294

Screen Shot 2023-03-04 at 8 17 38 pm

Screen Shot 2023-03-04 at 8 18 13 pm

Screen Shot 2023-03-04 at 8 19 17 pm

Screen Shot 2023-03-04 at 8 20 10 pm

@pfeerick
Copy link
Member

pfeerick commented Mar 7, 2023

Might need to play with the graph sizing a little more, instead of being a straight line now for a standard 1:1 curve it is now stepped, so seems to no longer be square.

e.g.
image

image

@pfeerick pfeerick added bug 🪲 Something isn't working UX-UI Related to user experience (UX) or user interface (UI) behaviour B&W Related generally to black and white LCD radios labels Mar 7, 2023
… symmetry. Adjust position crosshair to better fit curve line.
@philmoz
Copy link
Collaborator Author

philmoz commented Mar 7, 2023

Adjusted code to fit curve into new size.

Screen Shot 2023-03-07 at 5 04 47 pm

@pfeerick pfeerick modified the milestones: 2.9, 2.8.2 Mar 8, 2023
@pfeerick pfeerick merged commit bd1094f into EdgeTX:main Mar 8, 2023
pfeerick pushed a commit that referenced this pull request Mar 13, 2023
* Fixes for B&W radio UI screens.

* Fix curve display to fit new size. Adjust curve for better horizontal symmetry. Adjust position crosshair to better fit curve line.
@philmoz philmoz deleted the bw-ui-fixes branch October 9, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zorro display issues in Inputs and Mixes and Curves page.
2 participants