Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio) - Fix crash when editing multi module type on 212x64 LCD B&W radios. #3459

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 10, 2023

Fixes #3458

Add missing test for empty 'title' value.

@elecpower
Copy link
Collaborator

Tested with X9D+ sim and was unable to crash it.

@elecpower elecpower added bug 🪲 Something isn't working B&W Related generally to black and white LCD radios simulator labels Apr 10, 2023
@elecpower
Copy link
Collaborator

@pfeerick definitely one for 2.8.3

@pfeerick pfeerick added this to the 2.8.3 milestone Apr 11, 2023
@pfeerick
Copy link
Member

Yup, and damn... we fixed it back in #217 for the 128x64 but obviously never thought to apply the same fix to the 212x64 screen radios... lol

@pfeerick pfeerick merged commit 0754830 into EdgeTX:main Apr 11, 2023
34 checks passed
@philmoz philmoz deleted the fix-multi-module-edit-crash branch October 23, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios bug 🪲 Something isn't working simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Companion and simulator crashes changing external multi module protocol type on 212 x 64 LCD B&W radios
3 participants