Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cpn): External module form factor set in Radio Profile to allow aligning with firmware compile option #3628

Merged
merged 2 commits into from
Jul 16, 2023

Conversation

elecpower
Copy link
Collaborator

Summary of changes:

  • provide support for Rationalise module size handling #3624
  • add setting External Module to Radio Profiles
  • the setting default value is based on the radio type (None, Standard, Small, Both)
    'None' can be a hardware limitation or it is never used so force protocol to OFF
    'Both' if factory or custom mods to hardware. All protocols will be available.
  • existing profiles will have the value of 'Standard' set on first use (see RELEASE NOTE below). It is not practical to code the default for each profile as app settings are loaded prior to firmware/board objects
  • available external module protocols are based on the new setting (complete change to logic so high importance for regression testing)
  • new warning message when opening a model for editing if external module protocol is not supported by profile setting

RELEASE NOTE: Existing radio profiles will need to be changed if the default External Module value of 'Standard' is not correct for the radio

profilesettings

warningmsg

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels May 28, 2023
@pfeerick pfeerick self-assigned this Jul 3, 2023
@pfeerick pfeerick added this to the 2.10 milestone Jul 3, 2023
@pfeerick pfeerick added the rn: warning Warning needed in release notes label Jul 16, 2023
@pfeerick pfeerick merged commit 286ae00 into main Jul 16, 2023
3 checks passed
@pfeerick pfeerick deleted the elecpower/cpn-for-3624-ext-module branch July 16, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
companion Related to the companion software enhancement ✨ New feature or request rn: warning Warning needed in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants