SD card full warnings and functional degradation if SD card has less than 50MB free space #3730

mha1 · 2023-06-28T19:57:36Z

justification: #3666

Changes:

checks SD card free space at startup, start of logging and writing screenshots
issues warning to user if SD card has less than 50MB free space
will not write logs or screenshots if free space is less than 50MB at activation time
fixes crash on using popups in logs.cpp due to using software timers (Crash without EM after popup "SD card full" is issued by SD logs and USB is connected while popup is on display #3728)
commented out some annoying and misleading TRACE calls, e.g. 2.9: SD card write error "disk_write bad alignment" #3736

Note for testing: It is best to use a very small SD card, e.g. 256MB and check free space. Create TEMP directory and save arbitrary data to push SD card free space below the 50MB threshold.

- checks SD card free space at startup, start of logging and writing screenshots - issues warning to user if SD card has less than 50MB free space - will not write logs or screenshots if free space is less than 50MB at activation timerReset - fixes crash of warning popup in logs.cpp (EdgeTX#3728)

philmoz · 2023-06-28T22:34:35Z

I'm not sure whether it's a good idea to popup a full screen warning when the radio may be used to fly a model (screenshot or logging error).

This could result in the user being distracted or panicking and a crashed model.

At startup is fine; but perhaps the screenshot and logging checks should fail silently.

philmoz · 2023-06-28T22:39:56Z

I would also suggest adding detail to the TR_SDCARD_FULL string to tell users that screenshots (for color radios) and logging are disabled.

philmoz · 2023-06-28T22:48:30Z

Edit: Changing POPUP_WARNING() to POPUP_WARNING_ON_UI_TASK solves the problem.

The other places where POPUP_WARNING() is used in logs.cpp should probably also be changed as well.

philmoz · 2023-06-28T22:59:00Z

The card full check for logging is done only when the log file is opened.

It is theoretically possible for the log writing to open the file and then fill the SD card while logging.

Perhaps the check for free space should in logsWrite, and it should also close the log file if it then runs out of space while logging.

mha1 · 2023-06-28T23:47:38Z

Thanks for your feedback.

The full screen warning is only used at startup. While operating it's the smaller popups overlaying a portion of the screen.

I already changed all occurrences of the popup to UI_IN_TASK versions.

Sure I can amend the popup texts. Just used what was already there trying to avoid new text to be translated.

I thought about checking in logsWrite() too but wasn't sure about the time it takes to call for the sector count. I'll measure tomorrow and put the check in if the penalty is small enough to run it repeatedly. 50MB should be safe for another 3h of logging at the fastest rate but shutting down logging when the threshold is hit is clearly the better option.

gagarinlg · 2023-06-29T18:45:50Z

I think you do not check at every write. You know how many bytes each write writes and, normally, when logging, nothing else writes or can write huge amounts of data, because logging is not possible when USB is connected in storage mode and where should the data come from. So a quick sanity check every minute, or so, should be enough, when the limits leave enough room and then stop logging at 50MB free space left.
(Maybe different limits on the PL18, because it only has 8 MB flash)

pfeerick · 2023-06-30T00:09:01Z

Could be time-based, or interval based (i.e. check every 30 writes or something).

As an initial "don't crash the radio" fix, a silent "failure" would be fine, but a proper implementation should inform the user that the function triggered did not run (and why)... I know I would be very annoyed if logging was not running and I didn't know, especially when it's that time you're doing a test flight and something goes wrong. Or a screenshot of GPS coordinates or something, and the screenshot is not taken.

mha1 · 2023-06-30T18:26:24Z

I have updated this PR to cover 3 scenarios of SD card full:

At startup - will show the full screen warning just like throttle warning

At activation of logging or triggering a screenshot - this will show a popup "SD card full, Logs and Screenshots disabled", logging to SD card is not started

Having started logging above the threshold but meeting the threshold while logging - the log file will be closed and same popup as in 2

https://youtu.be/BWVWhEhBuds

I measured the time it takes to query the SD card driver for the number of free sectors. It takes a negligible 5.2us so I poll the SD card driver every log write cycle, i.e. at the same rate logging is happening. This means a worst case of 5.2us every 100ms.

The PR currently has 3 lines of code for testing scenario 2. It will start logging if the SD card is above threshold but mimic SD card full after 30 written log lines. To test in a real scenario comment lines 283-285, uncomment line 286 and make sure to start logging slightly above threshold.

I have tested this PR as much as I can but very much appreciate more testing.

@philmoz While testing with traces enabled I noticed some unexpected output upon closing the popup. The trace below shows the part right after calling POPUP_WARNING_ON_UI_TASK(), me trying to exit the popup by touch (works sometimes), me finally exiting the popup by using the RTN key and some unexpected complaints from the MPM and some garbled traces. I have tried multiple times. This is reproducible and happens right at exiting the popup. To me it looks like the popup writes to memory it shouldn't. This definitely needs some attention.

37.11s: calling popup
41.51s: touch state = 0x81
41.51s: touch event = DOWN
41.67s: touch state = 0x80
41.67s: touch event = UP
41.72s: touch state = 0x80
41.72s: touch event = NONE
41.76s: touch state = 0x80
41.76s: touch event = NONE
43.52s: touch state = 0x81
43.52s: touch event = DOWN
43.57s: touch state = 0x81
43.57s: touch event = DOWN
43.63s: touch state = 0x80
43.63s: touch event = UP
43.67s: touch state = 0x80
43.67s: touch event = NONE
43.69s: touch state = 0x80
43.69s: touch event = NONE
43.74s: touch state = 0x0
43.74s: touch event = NONE
44.99s: touch state = 0x81
44.99s: touch event = DOWN
45.12s: touch state = 0x80
45.12s: touch event = UP
45.16s: touch state = 0x80
45.16s: touch event = NONE
45.18s: touch state = 0x80
45.18s: touch event = NONE
49.07s: popup finished
49.07s: *** logsClose started obj.fs = 0
49.07s: *** stopping logging timer 0x20002c00
49.07s: *** logsClose finished obj.fs = 0
49.07s: [MP] invalid start byte 0x14
49.07s: [MP] invalid start byte 0xC9
49.07s: [MP] invalid start byte 0x02
49.07s: [MP] invalid start byte 0x1A
49.07s: [MP] invalid start byte 0x48
49.07s: [MP] invalid start byte 0x6F
49.07s: [MP] invalid start byte 0x54
49.07s: [MP] invalid start byte 0x54
49.07s: [MP] invalid start byte 0x00
49.07s: [MP] invalid start byte 0x4C
49.07s: [MP] invalid start b4949.49.49y4949.49 49<\n>4949.16s: *** init logging timer
49.16s: *** creating logging timer

@gagarinlg PL18 - did you mean 8GB?

gagarinlg · 2023-06-30T19:18:02Z

@gagarinlg PL18 - did you mean 8GB?

No, I meant 8 MB, maybe it sas 16 MB. There is a similar chip on the PL18 as in the X10, TX16S, ... and no SD card slot. So flash memeory is very limited on that radio.

pfeerick · 2023-06-30T20:58:21Z

No need to worry about the Pl18 in this PR, it's not a supported radio yet. More an issue for the virtualfs or whatever the branch is that adds support for it.

…

On Sat, 1 July 2023, 5:18 am Malte Langermann, ***@***.***> wrote: @gagarinlg <https://github.com/gagarinlg> PL18 - did you mean 8GB? No, I meant 8 MB, maybe it sas 16 MB. There is a similar chip on the PL18 as in the X10, TX16S, ... and no SD card slot. So flash memeory is very limited on that radio. — Reply to this email directly, view it on GitHub <#3730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KNQRZOZG3E2N6KWLZDXN4Q7LANCNFSM6AAAAAAZXS3AJI> . You are receiving this because you commented.Message ID: ***@***.***>

philmoz · 2023-06-30T22:16:07Z

While testing with traces enabled I noticed some unexpected output upon closing the popup.

I can't test this at the moment; but I suspect it may be because the POPUP_WARNING_ON_UI_TASK function blocks the calling task until the popup is closed.

You could try adding a parameter to the POPUP_WARNING_ON_UI_TASK function call to tell it not to do the wait loops waiting for the popup to be closed.

Example code below, change the call in logging to pass false as the last parameter.

popups.cpp

void POPUP_WARNING_ON_UI_TASK(const char * message, const char * info, bool waitForClose)
{
  // if already in a popup, and we don't want to wait, ignore call
  if (!waitForClose && ui_popup_active)
    return;

  // Wait in case already in popup.
  while (ui_popup_active) {
    RTOS_WAIT_MS(20);
  }
  ui_popup_title = "Warning";
  ui_popup_msg = message;
  ui_popup_info = info;
  ui_popup_active = true;

  // Wait until closed
  if (waitForClose) {
    while (ui_popup_active) {
      RTOS_WAIT_MS(20);
    }
  }
}

popups.h

void POPUP_WARNING_ON_UI_TASK(const char * message, const char * info = nullptr, bool waitForClose = true);

mha1 · 2023-07-01T03:01:51Z

@philmoz have you deleted your comment?

Just read the email but wasn't showing here. Now it is. Thanks for your suggestion, will try.

mha1 · 2023-07-01T07:55:18Z

@philmoz I think calling the popup in non-blocking mode did the trick. Many thanks!

mha1 · 2023-07-02T07:52:49Z

@philmoz I think we learned blocking the software timer task is not a good idea. This is why I checked other software timer instances for using popups. Apart from logging it's luckily only telemetry doing it in a rare context and condition:

radio/src/telemtry/telemetry.cpp:

I think this should also use the newly created non-blocking version of POPUP_WARNING_ON_UI_TASK(). What do you think?

philmoz · 2023-07-02T08:14:57Z

I think this should also use the newly created non-blocking version of POPUP_WARNING_ON_UI_TASK(). What do you think?

That will cause the 'radio antenna defective' sound to be played every ten seconds even when the popup is showing.
At the moment it only plays once when the popup appears.

mha1 · 2023-07-02T08:35:02Z

@pfeerick no problem this PR not making RC1 as it needs some more testing especially on b&w radios. And there is still code in for testing scenario 3 which I'd remove after confirmation.

@ParkerEde would be nice if you gave this a go on your X7 and X10s

The test scenarios to consider with SD card full

At startup - will show the full screen warning just like throttle warning
At activation of logging or triggering a screenshot - this will show a popup "SD card full, Logs and Screenshots disabled", logging to SD card is not started
Having started logging above the threshold but meeting the threshold while logging - the log file will be closed and same popup as in 2

Here's some test sequences also valid for the 2.8 PR (#3739):

Preparation: create SF's for logging and screenshots. Both SF's activated by a switch.

Test case scenario 3:

clear LOGS folder
just flash this PR's check firmware as it is
Power radio - expect normal startup
Activate logging - expect flashing log indicator and popup after logging rate times 30, e.g. 0.2s rate -> 6s.
Leave the system running for another minute or so
Exit popup - expect pop up closing but log indicator still flashing as logging is still activated
Deactivate logging - expect log indicator to stop flashing
Activate logging - expect log indicator flashing and immediate popup
Leave the system running for a minute or so
Deactivate logging - expect log indicator to stop flashing
Exit popup - expect pop up closing
Check LOGS folder - expect only one log file
Inspect log file - expect exactly 30 lines of log data

Test case scenario 1 and 2

Preparation: to test this without messing with the SD card you can check SD card free space with the SD card connected to a computer. Change opentx.h, search for IS_SDCARD_FULL() and change 50 to a value well over the number of Megabytes free on your SD card. Build and flash firmware with the changed value.

Clear LOGS folder
Power radio - expect warning message SD card full
Exit warning message - expect continuing normal start up
Activate screen shot - expect immediate popup
exit popup - expect pop up closing
Deactivate screen shot
Activate logging - expect flashing log indicator and immediate pop up
Leave the system running for another minute or so
Exit popup - expect pop up closing but log indicator still flashing as logging is still activated
Deactivate logging - expect log indicator to stop flashing
Activate logging - expect log indicator flashing and immediate popup
Leave the system running for a minute or so
Deactivate logging - expect log indicator to stop flashing
Exit popup - expect pop up closing
Check LOGS folder - expect no log file written
Check SCREENSHOTS folder - expect no screenshot written

mha1 · 2023-07-02T09:23:27Z

@philmoz which will probably be the right response to a bad antenna warning. If 10s is to much of a nuisance the rate could be changed to maybe 20s or 30s. I just think blocking the software timer task is not a good idea as we learnt

- turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls

ParkerEde · 2023-07-04T11:22:40Z

@mha1 Have now tested this PR. It now works great with SD card logs. The screen is switched back to bright on alarms and stick movements also make the screen bright again when the pop-up is open.

mha1 · 2023-07-09T07:31:20Z

@pfeerick Thanks for your review

mha1 · 2023-07-09T07:46:05Z

@pfeerick can you cherry-pick this version (2.9) into main?

pfeerick · 2023-07-09T08:27:00Z

I won't know for certain until it's merged (as I'll then have a single commit to pull across) but none of the changes stand out as being problematic/likely to cause a conflict.

mha1 · 2023-07-09T08:45:45Z

ok, I'll save the effort then and keep my fingers crossed

pfeerick · 2023-07-10T09:01:33Z

TheIsotopes · 2023-07-10T09:13:51Z

DE

#define TR_SDCARD_FULL                 "SD-Karte voll"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\nLogs und Screenshots deaktiviert"
#else
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\036Logs und " LCDW_128_480_LINEBREAK "Screenshots deaktiviert"
#endif

Pat6874 · 2023-07-10T09:14:22Z

FR: #define TR_SDCARD_FULL "SD carte pleine" #if defined(COLORLCD) #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nJournaux et Impr. écran désactivé" #else #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Journaux et " LCDW_128_480_LINEBREAK "Impr. écran désactivé" #endif @ Peter: did you see my last message with a better translation proposal? Le lun. 10 juil. 2023 à 11:01, Peter Feerick ***@***.***> a écrit :

…

Michael, adopt the brace position! 😆 Can we get some translations for this please 😃 The first phrase is essentially the title, and then the second phrase is identical but needs different formatting between colorlcd and B&W UIs - i.e. three lines on the smaller 128x64 display whereas the 212x64 is wide enough. #define TR_SDCARD_FULL "SD card full" #if defined(COLORLCD) #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLogs and Screenshots disabled" #else #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Logs and " LCDW_128_480_LINEBREAK "Screenshots disabled" #endif [image: snapshot_01] <https://user-images.githubusercontent.com/5500713/252286886-7c266d52-e29d-4096-adc7-d99ad2be2ab6.png> [image: snapshot_01] <https://user-images.githubusercontent.com/5500713/252288648-d2a06bd9-ebb5-4b4a-aedd-5a73ff252fa0.png> [image: snapshot_01] <https://user-images.githubusercontent.com/5500713/252288843-ef06e560-836a-4219-a3a0-e15ef84b7b75.png> - @zyren <https://github.com/zyren> CN / TW - @Eldenroot <https://github.com/Eldenroot> CZ - @HThuren <https://github.com/HThuren> DA - @ParkerEde <https://github.com/ParkerEde> / @TheIsotopes <https://github.com/TheIsotopes> DE - @Pat6874 <https://github.com/Pat6874> FR - @offer-shmuely <https://github.com/offer-shmuely> HE - @robustini <https://github.com/robustini> IT - @ToshihiroMakuuchi <https://github.com/ToshihiroMakuuchi> JP - @ulfhedlund <https://github.com/ulfhedlund> SE - @ajjjjjjjj <https://github.com/ajjjjjjjj> PL - @zandorsp <https://github.com/zandorsp> PT — Reply to this email directly, view it on GitHub <#3730 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6HE7XNLRWA3Z2SLYO44CPLXPPAHZANCNFSM6AAAAAAZXS3AJI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

robustini · 2023-07-10T09:26:30Z

IT

#define TR_SDCARD_FULL "SDCard piena"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLogs e Screenshots disattivati"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Logs e " LCDW_128_480_LINEBREAK "Screenshots disattivati"
#endif

zandorsp · 2023-07-10T10:58:50Z

PT

#define TR_SDCARD_FULL                 "Cartão SD cheio" 
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\nLogs e captura de tela desativados"
#else
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\036Logs e captura" LCDW_128_480_LINEBREAK "de tela desativados"
#endif

HThuren · 2023-07-10T11:07:19Z

DA
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLog og skærmklip deaktiveret"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Log og " LCDW_128_480_LINEBREAK "skærmklip deaktiveret"
#endif

Eldenroot · 2023-07-10T15:34:27Z

CZ

#define TR_SDCARD_FULL "Plná karta SD"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLogování dat a snímky obrazovky vypnuty"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Logy a " LCDW_128_480_LINEBREAK " Snímky obrazovky vypnuty"
#endif

mha1 · 2023-07-10T16:06:54Z

@pfeerick how about #define TR_SDCARD_FULL "\036Logs, Screenshots" LCDW_128_480_LINEBREAK "disabled" for b&w targets to avoid the 128x64 spill over.

Another option: #define TR_SDCARD_FULL "\036Logs & Screenshots" LCDW_128_480_LINEBREAK "disabled"

ajjjjjjjj · 2023-07-10T17:13:52Z

PL

#define TR_SDCARD_FULL                 "Pełna karta SD" 
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\nLogi i zrzuty ekranu wyłączone"
#else
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\036Logi i zrzuty ekranu" LCDW_128_480_LINEBREAK "wyłączone"
#endif

zyren · 2023-07-10T17:46:27Z

CN

#define TR_SDCARD_FULL                 "SD卡已满"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\n日志和截屏功能将被禁用"
#else
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\036日志和截屏 " LCDW_128_480_LINEBREAK "将被禁用"
#endif

TW

#define TR_SDCARD_FULL                 "SD卡已滿"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\n日誌和截屏功能將被禁用"
#else
#define TR_SDCARD_FULL_EXT             TR_SDCARD_FULL "\036日誌和截屏 " LCDW_128_480_LINEBREAK "將被禁用"
#endif

ulfhedlund · 2023-07-10T20:45:04Z

SE: ``` #define TR_SDCARD_FULL "SD-kortet fullt" #if defined(COLORLCD) #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLoggar och skärmklipp inaktiverade" #else #define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Loggar och " LCDW_128_480_LINEBREAK "skärmklipp inaktiverade" ```

pfeerick · 2023-07-11T00:25:55Z

@pfeerick how about #define TR_SDCARD_FULL "\036Logs, Screenshots" LCDW_128_480_LINEBREAK "disabled" for b&w targets to avoid the 128x64 spill over.

Another option: #define TR_SDCARD_FULL "\036Logs & Screenshots" LCDW_128_480_LINEBREAK "disabled"

Yeah, I was thinking something like that... or even just ordering so it was "screenshots and " "logs disabled", but had already pinged translators. Will probably still change it for English, individual translations will probably need to be tweaked over time to suite word lengths, etc. The spill-over still looks better/seemed more readable than on three lines 😆

offer-shmuely · 2023-07-11T05:33:55Z

#define TR_SDCARD_FULL "הדיסק מלא״
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\לוגים ושמירת צילומי מסך מושבתים"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036לוגים" LCDW_128_480_LINEBREAK "ושמירת צילומי מסך מושבתים"
#endif

mha1 · 2023-07-11T07:30:40Z

updated languages CN, CZ, DA, DE, FR, HE, IT, PL, PT, SE, TW

JP still open

mha1 · 2023-07-11T07:33:42Z

@zyren @Eldenroot @HThuren @TheIsotopes @Pat6874 @offer-shmuely @robustini @ulfhedlund @ajjjjjjjj @zandorsp

Thank you guys

@ToshihiroMakuuchi Please respond if you find the time

HThuren · 2023-07-11T09:17:12Z

@pfeerick how about #define TR_SDCARD_FULL "\036Logs, Screenshots" LCDW_128_480_LINEBREAK "disabled" for b&w targets to avoid the 128x64 spill over.
Another option: #define TR_SDCARD_FULL "\036Logs & Screenshots" LCDW_128_480_LINEBREAK "disabled"

Yeah, I was thinking something like that... or even just ordering so it was "screenshots and " "logs disabled", but had already pinged translators. Will probably still change it for English, individual translations will probably need to be tweaked over time to suite word lengths, etc. The spill-over still looks better/seemed more readable than on three lines 😆

If you like ?

DA
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLog & skærmklip deaktiveret"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Log & skærmklip" LCDW_128_480_LINEBREAK "deaktiveret"
#endif

robustini · 2023-07-11T12:43:08Z

IT
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nLogs e Screenshots disattivati"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Logs e Screenshots" LCDW_128_480_LINEBREAK "disattivati"
#endif

…ce (#3730) * justification: #3666 - checks SD card free space at startup, start of logging and writing screenshots - issues warning to user if SD card has less than 50MB free space - will not write logs or screenshots if free space is less than 50MB at activation timerReset - fixes crash of warning popup in logs.cpp (#3728) * update: warning message if SD card fills up to threshold while logging * empty commit * call popup in non-blocking mode * make b&w compatible to non-blocking popup calls * 2nd attempt * Popup: - turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls * #3599 * fixed b&w UI * updated languages CN, CZ, DA, DE, FR, HE, IT, PL, PT, SE, TW * chore: Update translations

…ce (#3739) * 2.8 port of #3730 (PR_SDCard_low_warning_2.9) * Popup: - turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls * remove test supporting code * fix b&w UI * updated languages CN, CZ, DA, DE, FR, IT, PL, PT, SE, TW * chore: Update translations

ToshihiroMakuuchi · 2023-07-15T01:28:25Z

JP

#define TR_SDCARD_FULL "SD card full"
#if defined(COLORLCD)
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\nログとスクリーンショット保存が無効"
#else
#define TR_SDCARD_FULL_EXT TR_SDCARD_FULL "\036Logs and " LCDW_128_480_LINEBREAK "Screenshots disabled"

…ce (#3730) * justification: #3666 - checks SD card free space at startup, start of logging and writing screenshots - issues warning to user if SD card has less than 50MB free space - will not write logs or screenshots if free space is less than 50MB at activation timerReset - fixes crash of warning popup in logs.cpp (#3728) * update: warning message if SD card fills up to threshold while logging * empty commit * call popup in non-blocking mode * make b&w compatible to non-blocking popup calls * 2nd attempt * Popup: - turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls * #3599 * fixed b&w UI * updated languages CN, CZ, DA, DE, FR, HE, IT, PL, PT, SE, TW * chore: Update translations

…ce (#3802) * fix: Prevent functional degradation if SD has less than 50MB free space (#3730) * justification: #3666 - checks SD card free space at startup, start of logging and writing screenshots - issues warning to user if SD card has less than 50MB free space - will not write logs or screenshots if free space is less than 50MB at activation timerReset - fixes crash of warning popup in logs.cpp (#3728) * update: warning message if SD card fills up to threshold while logging * empty commit * call popup in non-blocking mode * make b&w compatible to non-blocking popup calls * 2nd attempt * Popup: - turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls * #3599 * fixed b&w UI * updated languages CN, CZ, DA, DE, FR, HE, IT, PL, PT, SE, TW * chore: Update translations * chore: Remove magic number * chore: JP language update for SD card full (#3809) * fix: Don't spam simulator log with file close msgs --------- Co-authored-by: Michael <mha1@users.noreply.github.com>

pfeerick modified the milestones: 2.8.5, 2.9 Jun 30, 2023

mha1 added 2 commits June 30, 2023 19:14

update: warning message if SD card fills up to threshold while logging

94143b9

empty commit

154d623

call popup in non-blocking mode

a6bbe79

mha1 added 2 commits July 1, 2023 10:06

make b&w compatible to non-blocking popup calls

59ae247

2nd attempt

7f3b5d3

mha1 added a commit to mha1/edgetx that referenced this pull request Jul 1, 2023

2.8 port of EdgeTX#3730 (PR_SDCard_low_warning_2.9)

b216523

mha1 mentioned this pull request Jul 1, 2023

SD card full warnings and functional degradation if SD card has less than 50MB free space - 2.8 port #3739

Merged

Popup:

af1c947

- turns on backlight if dimmed due to inactivity setting - if backlight is dimmed due to inactivity setting backlight can turnd on again by any controls

updated languages CN, CZ, DA, DE, FR, HE, IT, PL, PT, SE, TW

26b6fa3

chore: Update translations

51f49d1

pfeerick merged commit 903029b into EdgeTX:2.9 Jul 14, 2023
19 checks passed

pfeerick mentioned this pull request Jul 14, 2023

fix: Prevent functional degradation if SD has less than 50MB free space (#3730) #3802

Merged

SD card full warnings and functional degradation if SD card has less than 50MB free space #3730

SD card full warnings and functional degradation if SD card has less than 50MB free space #3730

Conversation

mha1 commented Jun 28, 2023 • edited Loading

philmoz commented Jun 28, 2023

philmoz commented Jun 28, 2023

philmoz commented Jun 28, 2023

philmoz commented Jun 28, 2023

mha1 commented Jun 28, 2023 • edited Loading

gagarinlg commented Jun 29, 2023

pfeerick commented Jun 30, 2023

mha1 commented Jun 30, 2023

gagarinlg commented Jun 30, 2023 • edited Loading

pfeerick commented Jun 30, 2023 via email

philmoz commented Jun 30, 2023

mha1 commented Jul 1, 2023 • edited Loading

mha1 commented Jul 1, 2023

mha1 commented Jul 2, 2023

philmoz commented Jul 2, 2023

mha1 commented Jul 2, 2023

mha1 commented Jul 2, 2023 • edited Loading

ParkerEde commented Jul 4, 2023

mha1 commented Jul 9, 2023

mha1 commented Jul 9, 2023

pfeerick commented Jul 9, 2023

mha1 commented Jul 9, 2023

pfeerick commented Jul 10, 2023 • edited Loading

TheIsotopes commented Jul 10, 2023

Pat6874 commented Jul 10, 2023 via email

robustini commented Jul 10, 2023

zandorsp commented Jul 10, 2023

HThuren commented Jul 10, 2023

Eldenroot commented Jul 10, 2023 • edited Loading

mha1 commented Jul 10, 2023

ajjjjjjjj commented Jul 10, 2023

zyren commented Jul 10, 2023 • edited Loading

ulfhedlund commented Jul 10, 2023 via email • edited by pfeerick Loading

pfeerick commented Jul 11, 2023 • edited Loading

offer-shmuely commented Jul 11, 2023

mha1 commented Jul 11, 2023

mha1 commented Jul 11, 2023 • edited Loading

HThuren commented Jul 11, 2023

robustini commented Jul 11, 2023 • edited Loading

ToshihiroMakuuchi commented Jul 15, 2023

mha1 commented Jun 28, 2023 •

edited

Loading

mha1 commented Jun 28, 2023 •

edited

Loading

gagarinlg commented Jun 30, 2023 •

edited

Loading

mha1 commented Jul 1, 2023 •

edited

Loading

mha1 commented Jul 2, 2023 •

edited

Loading

pfeerick commented Jul 10, 2023 •

edited

Loading

Eldenroot commented Jul 10, 2023 •

edited

Loading

zyren commented Jul 10, 2023 •

edited

Loading

ulfhedlund commented Jul 10, 2023 via email •

edited by pfeerick

Loading

pfeerick commented Jul 11, 2023 •

edited

Loading

mha1 commented Jul 11, 2023 •

edited

Loading

robustini commented Jul 11, 2023 •

edited

Loading