Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy UI for telemetry type #3782

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Jul 8, 2023

Fixes #3776

Summary of changes:

  • remove legacy UI for telemetry type
  • CPN and b&w radios, was already deleted in color LCD UI

@mha1 mha1 force-pushed the PR_remove_legacy_protocol_type_UI branch from 5f04fa9 to b278502 Compare August 1, 2023 18:25
@raphaelcoeffic
Copy link
Member

@mha1 if I understand this well, this is basically the second phase of #3352, right? Basically in the same "group of features" as #3780.

@mha1
Copy link
Contributor Author

mha1 commented Aug 12, 2023

@raphaelcoeffic @pfeerick correct, this PR gets rid of the old zombie FrSky implementation which only made it half way into EdgeTX (b&W only), caused Companion to crash and created problems for a few users migrating from OpenTX on color radios. The good thing is it was hardly used anyways.

#3352 can serve as a template how to do it right in #3780's spirit.

Peter and I discussed the removal and are aware we might cause some (most likely only a handful) users a headache. The remedy would be to discuss the specific use case and extend the required module's capability as shown in #3352. The way the current old FrSky focused implementation handles things is incomplete and not worth keeping alive.

@raphaelcoeffic
Copy link
Member

Thx @mha1 this is real documentation for the posterity!

@pfeerick pfeerick self-requested a review September 4, 2023 09:19
@pfeerick pfeerick changed the title CPN and radio: remove legacy UI for telemetry type chore: Remove legacy UI for telemetry type Sep 4, 2023
@pfeerick pfeerick added this to the 2.10 milestone Sep 4, 2023
@pfeerick pfeerick added this to In progress in Code clean-up via automation Sep 4, 2023
@pfeerick pfeerick added B&W Related generally to black and white LCD radios companion Related to the companion software labels Sep 4, 2023
@pfeerick
Copy link
Member

pfeerick commented Sep 7, 2023

From what I can tell, this is as expected. X9D+2019 doesn't have any issues in the telemetry screen as a consequence of this PR. I can't test the Companion side changes atm as it seems PPM is missing from the external module list atm (not related to this PR) but they look ok.

@pfeerick pfeerick merged commit 73a4a23 into EdgeTX:main Sep 7, 2023
39 checks passed
Code clean-up automation moved this from In progress to Done Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios companion Related to the companion software
Projects
No open projects
Code clean-up
  
Done
Development

Successfully merging this pull request may close these issues.

CPN (possibly radios too): b&w radio Simu crashes on scrolling through telemetry protocol option
3 participants