fix: Deactivate logs and close log file if USB is connected #4024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a glance it looks fine, so I'll probably push this to 2.9 and 2.8 branches. There aren't any 2.8 releases planned at this time, but it'll be there if that changes. |
|
what's going on with checks? |
|
Changes to the docker container meaning a recent change in main is needed. |
|
yes, I figured. libclang missuing. checks ran fine after rebasing 1h ago |
|
Not as easy as I expected to repo... on the TX16S with default 1s logging it actually didn't seem to want to error on me... when I brought it down to 0.3s it started breaking 😆 |
pfeerick
changed the title
pfeerick
pushed a commit
that referenced
this pull request
Sep 24, 2023
pfeerick
pushed a commit
that referenced
this pull request
Sep 24, 2023
|
don't you hate those sneaky little bastards that are trying to trick you into thinking everything is ok? Thanks for merging. |
gagarinlg
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4023