Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Touch Screen Mod on Horus X10 Transmitters #4151

Merged
merged 1 commit into from Dec 23, 2023

Conversation

MRC3742
Copy link
Contributor

@MRC3742 MRC3742 commented Oct 2, 2023

Fixes #4114

Changes to allow the Touch Screen Mod for the Horus X10 Series of Transmitters.
This Mod requires some soldering directly to the MCU processor pins as no other connection points are available!

This is very similar to the already documented Jumper T16 Mod (PR #2060) that has been successfully added to EdgeTX.
The X10 / X10S Standard (NOT EXPRESS) radios need an additional pull down 1K resistor attached to MCU pin 55 (PA6)
This will allow the firmware to pass the PCBREV check as intended to distinguish between Standard or EXPRESS mainboards.

The X10 / X10S EXPRESS radios do not need this additional pulldown as they will already pass the check after installing the Mod.

Rich

@pfeerick
Copy link
Member

I'm just going to push a rebase of this to remove the unrelated commits. As a side note, this really should have been targeted for the main branch, not 2.9.

@pfeerick
Copy link
Member

@raphaelcoeffic Your thoughts? It looks ok to me, just checking before I press that adorable green button...

@pfeerick pfeerick added this to the 2.9.3 milestone Dec 22, 2023
@MRC3742
Copy link
Contributor Author

MRC3742 commented Dec 22, 2023

Thanks - I was trying to rebase this PR and................... well you see what happened !!!

I have also tested this PR using the main branch and it works correctly on my Horus X10 (Now with IPS Touch Screen)

Thanks Again - Rich

@pfeerick
Copy link
Member

lol... no problem... rebase can lead to some quite ... interesting... results sometimes.

Glad to hear it, and thanks for the photos and notes in the issue documenting it (will have to add to that to the wiki)... I expect this should be in tomorrow unless some French dude has any grievances... 🤭

@MRC3742
Copy link
Contributor Author

MRC3742 commented Dec 22, 2023

OK - I'll add a little more detail in that issue documenting the upgrade that is being added 🙏 by this PR.

Rich

@pfeerick pfeerick merged commit ff99896 into EdgeTX:2.9 Dec 23, 2023
34 checks passed
@MRC3742 MRC3742 deleted the X10_addTouch branch December 23, 2023 01:48
pagrey pushed a commit to pagrey/edgetx that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware support touch 👆 Related to touch interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants