Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color): 'SWITCH' widget option logic, enable for Lua widgets #4190

Merged
merged 2 commits into from Oct 16, 2023
Merged

fix(color): 'SWITCH' widget option logic, enable for Lua widgets #4190

merged 2 commits into from Oct 16, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Oct 11, 2023 •
edited by pfeerick

Fixes #3340

  • Logic for SWITCH option was using unsigned values instead of signed values.
  • Added missing setup code for Lua widget and constant for SWITCH option selection.

@pfeerick pfeerick added bug 🪲 Something isn't working color Related generally to color LCD radios labels Oct 11, 2023
@pfeerick pfeerick added this to the 2.10 milestone Oct 11, 2023
@pfeerick pfeerick self-requested a review October 13, 2023 10:41
@pfeerick
Copy link
Member

While this fixes the SWITCH logic so that that now works, I'm not entirely sure that is what #3340 was in relation to, as if the widget in question was using SWITCH, it would have appeared as a numerical edit field, and it doesn't sound like it was using SOURCE, otherwise it would have had more than just the fields the OP commented on.

@pfeerick pfeerick mentioned this pull request Oct 16, 2023
Closed
1 task
@pfeerick pfeerick changed the title fix(color): Fix 'SWITCH' widget option logic and enable for Lua scripts. fix(color): 'SWITCH' widget option logic, enable for Lua widgets Oct 16, 2023
@pfeerick pfeerick merged commit 1e3f919 into EdgeTX:main Oct 16, 2023
37 checks passed
@pfeerick pfeerick modified the milestones: 2.10, 2.9.x Oct 16, 2023
@pfeerick
Copy link
Member

This looks like it cleanly cherry-picks into 2.9, so will include it there also.

pfeerick pushed a commit that referenced this pull request Oct 18, 2023
@philmoz @pfeerick
fix(color): 'SWITCH' widget option logic, enable for Lua widgets (#4190)
676a5bf
@pfeerick pfeerick modified the milestones: 2.9.x, 2.9.2 Oct 18, 2023
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
@philmoz @MRC3742
fix(color): 'SWITCH' widget option logic, enable for Lua widgets (Edg…
ba50b74 
…eTX#4190)
@philmoz philmoz deleted the lua-widget-switch-option branch January 24, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
bug 🪲 Something isn't working color Related generally to color LCD radios
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

! Switches not showing in Widget Settings
2 participants
@philmoz @pfeerick