Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tts): DE play value "TIME" wrong for 00:xx:xx hours #4242

Merged
merged 2 commits into from Oct 27, 2023
Merged

fix(tts): DE play value "TIME" wrong for 00:xx:xx hours #4242

merged 2 commits into from Oct 27, 2023

Conversation

mha1
Copy link
Contributor

@mha1 mha1 commented Oct 25, 2023 •
edited

Fixes #4235

Summary of changes:

  • fixed use of singular and plural in TIME tts
  • removed "and" between hours and minutes (as is implemented for language EN) to make for shorter and more concise "TIME" speech messages

@mha1 mha1 marked this pull request as draft October 25, 2023 09:22
@mha1 mha1 marked this pull request as ready for review October 25, 2023 09:54
@mha1
Copy link
Contributor Author

mha1 commented Oct 25, 2023

tested on TX16s (DE language build) using sources "tmr1" and "Time"

@mha1 mha1 mentioned this pull request Oct 25, 2023
Closed
1 task
@mha1
Copy link
Contributor Author

mha1 commented Oct 25, 2023

@pfeerick I built a 2.9.1+ version for the problem finder to confirm the fix. 2.9.1 based because you know main and then going back to 2.9 ...

Please let me know if you consider this to be 2.9.2 worthy. Would be very easy to do but should be preceded by #3920

@pfeerick pfeerick added translation sound 🔉 Related to generated or played audio/sound labels Oct 27, 2023
@pfeerick pfeerick added this to the 2.9.2 milestone Oct 27, 2023
@pfeerick
Copy link
Member

If as native speakers you're happy with it as it is, since it really only affects you guys, should be fine. #3920 seems to have cherrypicked cleanly into 2.9, I'll see if this co-operates also...

@pfeerick pfeerick changed the title fix(language DE): play value "TIME" wrong for 00:xx:xx hours fix(tts): DE play value "TIME" wrong for 00:xx:xx hours Oct 27, 2023
@pfeerick pfeerick merged commit 51aa5a8 into EdgeTX:main Oct 27, 2023
37 checks passed
pfeerick pushed a commit that referenced this pull request Oct 27, 2023
@mha1 @pfeerick
fix(tts): DE play value "TIME" wrong for 00:xx:xx hours (#4242)
5c2acb1
@pfeerick pfeerick deleted the fix_#4235_time_wrong_after_midnight branch October 27, 2023 08:49
MRC3742 pushed a commit to MRC3742/edgetx that referenced this pull request Dec 22, 2023
@mha1 @MRC3742
fix(tts): DE play value "TIME" wrong for 00:xx:xx hours (EdgeTX#4242)
071416d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sound 🔉 Related to generated or played audio/sound translation
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

Play value "TIME" wrong after midnight
2 participants
@mha1 @pfeerick