Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color): Special/Global functions from 2.9 not imported correctly in 2.10. #4498

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Dec 31, 2023

Fixes #4495

Fix for reading 2.9 model files in 2.10 - correctly handle 2.9 special/global function syntax.

@pfeerick pfeerick added bug/regression ↩️ A new version of EdgeTX broke something storage Related to loading, saving, converting labels Dec 31, 2023
@pfeerick pfeerick added this to the 2.10 milestone Dec 31, 2023
@ParkerEde
Copy link
Contributor

Nice job. Thx.
Two things are still inactive after update to 2.10 (in 2.9 was active)

  1. Function "SD Logs" is inactive
  2. Function "Vario" is inactive

@philmoz
Copy link
Collaborator Author

philmoz commented Jan 1, 2024

I've added a fix for SD Logs (and Haptic).

Unfortunately I don't think there is anything I can do for Vario and other functions that have no extra parameters. The code that parses the function parameters is not called when the parameter list is empty so there is no opportunity to set the enabled flag.

This affects Instant Trim, BG Music Pause, Vario, Screenshot, Racing Mode, Disable Touch, and Audio Amp Off.

@pfeerick The release notes for 2.10 will need to mention that the above SF/GF will need to be manually enabled after update.

@pfeerick pfeerick added the rn: warning Warning needed in release notes label Jan 1, 2024
@pfeerick
Copy link
Member

pfeerick commented Jan 3, 2024

Is this a side effect of when the default for the active flag was changed in #3601?

@philmoz
Copy link
Collaborator Author

philmoz commented Jan 3, 2024

Is this a side effect of when the default for the active flag was changed in #3601?

It's a side effect of 3601 because functions that did not have an enable flag now do, and the value of the flag defaults to 0 (not enabled).

@pfeerick pfeerick merged commit 2d877d4 into EdgeTX:main Jan 4, 2024
39 checks passed
@philmoz philmoz deleted the fix-cfn-ver-update branch April 9, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something rn: warning Warning needed in release notes storage Related to loading, saving, converting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion of special functions from 2.9 to 2.10 faulty
3 participants