Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pl18): USB detect pin can be uninitialized in bootloader #4891

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

richardclli
Copy link
Collaborator

When work on some further development, discovered that the USB detection pin in PL18/PL18EV can be uninitialized in bootloader mode, this can cause potential problem.

@richardclli richardclli added this to the 2.10 milestone Apr 17, 2024
@pfeerick pfeerick added the bug 🪲 Something isn't working label Apr 17, 2024
Copy link
Contributor

@mha1 mha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you do something like this to avoid stack garbage on potentially unused struct members?

GPIO_InitTypeDef GPIO_InitStruct = {0};

@richardclli
Copy link
Collaborator Author

No need:

  1. All members are already covered in this code
  2. This is only a quick fix for transition, next version will change to LL library.

shouldn't you do something like this to avoid stack garbage on potentially unused struct members?

GPIO_InitTypeDef GPIO_InitStruct = {0};

@pfeerick pfeerick merged commit 9701088 into main Apr 21, 2024
44 checks passed
@pfeerick pfeerick deleted the fix-pl18-bl-usb-detect branch April 21, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants