chore(t14): remove unused ws2812 #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3djc
added
hardware support
partner
3djc
changed the title
pfeerick
changed the title
pfeerick
reviewed
Apr 21, 2024
| @@ -625,7 +625,7 @@ if(PCB STREQUAL XLITE OR PCB STREQUAL XLITES OR PCBREV STREQUAL COMMANDO8) | |||
| targets/common/arm/stm32/sticks_pwm_driver.cpp) | |||
| endif() | |||
|
|
|||
| if(PCBREV STREQUAL MT12 OR PCBREV STREQUAL T14) | |||
| if(PCBREV STREQUAL MT12) | |||
There was a problem hiding this comment.
Maybe in future these should be more feature flags rather than radio specific? i.e. I could see this and the above (sticks_pwm_driver) being more generic...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed as per Jumper request as it is not available on final hardware