Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hal): remove StdPeriph #5023

Merged
merged 30 commits into from
Jun 1, 2024
Merged

chore(hal): remove StdPeriph #5023

merged 30 commits into from
Jun 1, 2024

Conversation

raphaelcoeffic
Copy link
Member

Please note that the new GPIO driver has been ported from RIOT-OS.

@raphaelcoeffic raphaelcoeffic force-pushed the obsolete-stdperiph branch 2 times, most recently from 97f67a8 to 5abcc5d Compare May 16, 2024 14:04
@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label May 17, 2024
@pfeerick pfeerick added this to the 2.11 milestone May 17, 2024
@pfeerick pfeerick changed the title chore(HAL): remove StdPeriph chore(hal): remove StdPeriph May 17, 2024
@richardclli
Copy link
Collaborator

@raphaelcoeffic Please help to check what I have fixed, especially the sdram drivers.

@pfeerick
Copy link
Member

pfeerick commented May 25, 2024

Well, out of the seven transmitters I've tried so far, the Pocket, X9D+, TPro, T20 won't even boot up - just power led and maybe backlight, and only the EL18, PL18EV & TX16S are booting up with the current state of this PR... so something is majorly wrong atm. 🤪

edit: TX16S was just sat idling while I was typing this (as it often is as it's on a power supply), and it suddenly EM'd.

@3djc
Copy link
Collaborator

3djc commented May 25, 2024

Well, out of the seven transmitters I've tried so far, the Pocket, X9D+, TPro, T20 won't even boot up - just power led and maybe backlight, and only the EL18, PL18EV & TX16S are booting up with the current state of this PR... so something is majorly wrong atm. 🤪

edit: TX16S was just sat idling while I was typing this (as it often is as it's on a power supply), and it suddenly EM'd.

Boot issues should be fixed.

But I think I found another one, jack trainer seem unavailable

@3djc
Copy link
Collaborator

3djc commented May 26, 2024

Bootloader should be fixed.

T20 passthrough. Are we talking T20 or T20V2 ?

@pfeerick
Copy link
Member

pfeerick commented May 26, 2024 via email

@3djc
Copy link
Collaborator

3djc commented May 26, 2024

T20... Can try the V2.

On Sun, 26 May 2024, 4:47 pm 3djc, @.> wrote: Bootloader should be fixed. T20 passthrough. Are we talking T20 or T20V2 ? — Reply to this email directly, view it on GitHub <#5023 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ66KPW2HCLWLNY4B3D2NTZEGARBAVCNFSM6AAAAABH2HXZGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGA4TCNJUGQ . You are receiving this because you commented.Message ID: @.>

Nop, seems to be all radio, on it

@pfeerick
Copy link
Member

Yup, was just about to say Pocket also, thanks :)

@philmoz
Copy link
Collaborator

philmoz commented May 28, 2024

TX16S & EL18:

  • Flashed via DFU, both firmware & bootloader work
  • Flash bootloader from firmware SD manager - radio is bricked, neither firmware or BL will start. Requires DFU flash to recover.

T20V2 has the same issue.

@3djc
Copy link
Collaborator

3djc commented May 30, 2024

Last remaining issues

  • passthrough flashing
  • possible crackling noise on boot (tx16s & t20v2, reported by Philmoz)

@3djc
Copy link
Collaborator

3djc commented May 31, 2024

Afaik, no outstanding issues reported (yet ?)

@3djc
Copy link
Collaborator

3djc commented May 31, 2024

Merge me merge me merge me :D

@pfeerick
Copy link
Member

pfeerick commented May 31, 2024 via email

@gagarinlg
Copy link
Member

But they have all been fixed
🙏

@pfeerick
Copy link
Member

pfeerick commented May 31, 2024 via email

@pfeerick
Copy link
Member

pfeerick commented Jun 1, 2024

TPro:
🟢 boots, rf link (ELRS), telemetry, haptic, audio, usb joystick, usb SD, yaapu lua, elrs passthrough, able to flash bootloader from firmware, flash other firmware from PR bootloader
🟠 bootloader is still not quite right - is quite slow to start compared to pre PR, and is somewhat unresponsive to button presses when using. but is functioning. bootloader usb does not connect - attempts but does not enumerate.

TX16S:
🟢 boots, rf link (MPM Frsky X), telemetry, haptic, audio, flash internal MPM, usb joystick, usb storage, bootloader usb works, able to flash bootloader from firmware, flash other firmware from PR bootloader, random EMs appear to be gone

Pocket:
🟢 boots, rf link (ELRS), telemetry, haptic, audio, able to flash bootloader from firmware, flash other firmware from PR bootloader, usb storage, usb joystick, bootloader usb works

X9D+:
🟢 boots, rf link (XJT), telemetry, haptic, audio, able to flash bootloader from firmware, flash other firmware from PR bootloader
🟠 bootloader is still not quite right - is quite slow to start compared to pre PR, and is somewhat unresponsive to button presses when using. but is functioning. bootloader usb does not enumerate

T20:
🟢 boots, rf link (ELRS), telemetry, haptic, audio, bootloader usb works, usb storage, elrs passthrough, able to flash bootloader from firmware, flash other firmware from PR bootloader,

PL18EV:
🟢 boots, rf link (ext MPM, Frsky X), telemetry, haptic, audio, able to flash bootloader from firmware, usb storage, usb joystick, bootloader usb

EL18:
🟤 still having issues with SD card that came with one EL18, will need to investigate further to determine culprit, but it seems sd card specific

Considering the issues still outstanding (that we know of so far) can be mitigated by simply not updating the bootloader until they are resolved, I have no issue with merging this now and fixing up on the fly. Just to elaborate further on the sluggish bootloader / no usb enumeration, I also tried the TX12 in addition to the prior radios, and it had the issue also, so would appear to be common to STM32F205xE radios ;)

@richardclli
Copy link
Collaborator

richardclli commented Jun 1, 2024

I have played around my EL18 and did not spot any problems, so what is your SD card problem about?

@pfeerick
Copy link
Member

pfeerick commented Jun 1, 2024

See #5023 (comment)

Basically it would boot up, get past the warnings, and then reboot into a endless loop where it would vibrate and then reboot again.

@pfeerick pfeerick merged commit 6579905 into main Jun 1, 2024
44 checks passed
@pfeerick pfeerick deleted the obsolete-stdperiph branch June 1, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants